Date: Mon, 18 Feb 2002 22:33:12 -0800 From: Peter Wemm <peter@wemm.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: current@FreeBSD.ORG Subject: Re: Patch sets to date and timing tests with Giant out of userret. Message-ID: <20020219063312.66ACD3BAD@overcee.wemm.org> In-Reply-To: <200202182009.g1IK9Sh36025@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon wrote: > - mtx_lock(&Giant); > - td->td_retval[0] = p->p_ucred->cr_ruid; > + s = mtx_lock_giant(kern_giant_ucred); > + td->td_retval[0] = td->td_ucred->cr_ruid; > #if defined(COMPAT_43) || defined(COMPAT_SUNOS) > - td->td_retval[1] = p->p_ucred->cr_uid; > + td->td_retval[1] = td->td_ucred->cr_uid; > #endif > - mtx_unlock(&Giant); > + mtx_unlock_giant(s); > return (0); What a waste.. John has already done all this stuff already (using td_ucred instead of p_ucred) over the entire tree. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020219063312.66ACD3BAD>