Date: Sat, 05 Mar 2016 16:38:21 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207657] games/fairymax: Update to 5.0b Message-ID: <bug-207657-13-vqUdnJ25rz@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-207657-13@https.bugs.freebsd.org/bugzilla/> References: <bug-207657-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207657 Raphael Kubo da Costa <rakuco@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco@FreeBSD.org --- Comment #4 from Raphael Kubo da Costa <rakuco@FreeBSD.org> --- Hi Kalten, I have some suggestions for your update: - share/games/plugins looks like a very generic directory for fairymax to u= se. How about setting |plugindir| to ${DATADIR}/plugins in MAKE_ARGS. - INI_Q already seems to be set to ${DATADIR}/qmax.ini since you set fairyd= ir to ${DATADIR}, so I guess you don't need to explicitly set it. - "-O2" doesn't really justify having an OPTIMIZED_CFLAGS option. It's pass= ed by default by the ports tree along with "-pipe -fstack-protector -fno-strict-aliasing". - The fairymax.pod sed call doesn't seem to be replacing anything in this version. - fairymax's Makefile already has an install target, do you really need to = have a custom do-install target yourself? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207657-13-vqUdnJ25rz>