Date: Fri, 20 May 2005 15:03:58 GMT From: Danny Pansters <danny@ricin.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/81309: multimedia/mplayer: fix for bsdbt848 with secam norm Message-ID: <200505201503.j4KF3wnl043975@www.freebsd.org> Resent-Message-ID: <200505201510.j4KFA1eY059606@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 81309
>Category: ports
>Synopsis: multimedia/mplayer: fix for bsdbt848 with secam norm
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri May 20 15:10:01 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Danny Pansters
>Release: 5.4-STABLE
>Organization:
>Environment:
FreeBSD desktop.homenet 5.4-STABLE FreeBSD 5.4-STABLE #15: Fri Apr 29 20:15:48 CEST 2005
root@desktop.homenet:/usr/obj/usr/src/sys/DESKTOP i386
>Description:
In libmpdemux/tvi_bsdbt848 there's code to set the input format using METEOR_FMT_*. This doesn't seem to work for SECAM. I'm not sure why.
>How-To-Repeat:
Try something like:
%mplayer -vo xv -framedrop -nocache -quiet -tv driver=bsdbt848:device=/dev/bktr:input=1:norm=secam tv://
MPlayer 1.0pre7-3.4.2 (C) 2000-2005 MPlayer Team
CPU: Intel Pentium 4/Xeon/Celeron Northwood (Family: 8, Stepping: 4)
Detected cache-line size is 64 bytes
CPUflags: MMX: 1 MMX2: 1 3DNow: 0 3DNow2: 0 SSE: 1 SSE2: 1
Compiled for x86 CPU with extensions: MMX MMX2 SSE SSE2
Playing tv://.
TV detected! ;-)
Selected driver: bsdbt848
name: Brooktree848 Support
author: Charles Henrich
comment: in development
format:ioctl: Invalid argument
Error: Cannot set norm!
>Fix:
It's probably best to avoid as many of the METEOR_* if an alternative ioctl or constant from ioctl_bt848.h can be used, but simply changing the one occurence of METEOR_FMT_SECAM to BT848_IFORM_F_SECAM seems to be fine. I suggest adding this to the Makefile in postpatch stage:
@${REINPLACE_CMD} -e 's|METEOR_FMT_SECAM|BT848_IFORM_F_SECAM|' ${WRKSRC}/libmpdemux/tvi_bsdbt848.c
I have PAL here, so all I could test was that the error went away.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200505201503.j4KF3wnl043975>