Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 May 2005 12:25:34 +0200
From:      Markus Brueffer <markus@FreeBSD.org>
To:        freebsd-acpi@freebsd.org
Cc:        freebsd-mobile@freebsd.org
Subject:   Re: Call for testers: New acpi_ibm driver
Message-ID:  <200505311225.40954.markus@FreeBSD.org>
In-Reply-To: <200505310155.KAA00994@axe-inc.co.jp>
References:  <200505310155.KAA00994@axe-inc.co.jp>

next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1475104.nWk98nXePS
Content-Type: text/plain;
  charset="iso-8859-6"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Tuesday 31 May 2005 03:55, takawata@jp.freebsd.org wrote:
> In message <200505301857.20346.markus@FreeBSD.org>, Markus Brueffer wrote:
> >In any case: Please send me your DSDT for further improvement of the
> > driver=3D =3D20
> >(even if you run FreeBSD 5):
> ># acpidump -t -d > name-system.asl
>
> http://www.init-main.com/acpi_tpkey/TPX31JHJ.asl

Thanks!

> >Changes:
> >
> > Relocation of the sysctl tree to hw.acpi.ibm and renaming of some
> > sysctls
>
> I don't think it a good thing. New device specific tree
> should not be introduced.

I tried to get the sysctls more in line with our other ACPI extras drivers,=
=20
which all reside under hw.acpi.<brand> and hence the rename of e.g.=20
brightness->lcd_brightness and the relocation of the tree. Is there some=20
policy where such stuff belongs to?

> > Support for more hotkeys by the hotkey sysctl (see manpage)
> > Improved support of ACPI events, disabled by default. You can enable it
> > by setting the events sysctl to 1 (on my T41p there are now 24
> > different keypress events that get reported)
> > write support for: volume, mute, brightness and thinklight
>
> Is it ok to  touch EC? I know the two way of impliment it.
> One is modifying RTC register, another is using SMI interface
> via ACPI control method.

Writing to the EC directly is nothing more that accessing the locations via=
=20
acpi_SetInteger. While I would highly prefer the latter method, the problem=
=20
is, that several places of the EC in the DSDT aren't even named or only=20
named on some models. Consider e.g. setting volume and mute. Here is a=20
snippet of a T41p DSDT:

                Device (EC)
                {
[...]
                    OperationRegion (ECOR, EmbeddedControl, 0x00, 0x0100)
                    Field (ECOR, ByteAcc, NoLock, Preserve)
                    {
                        HDBM,   1,
                            ,   1,
                            ,   1,
[...]
                        HFSP,   8,
                            ,   6,    <-- Volume
                        HMUT,   1,    <-- Mute
                        Offset (0x31),
                        HBRV,   8,    <-- Brightness
                        HWPM,   1,

Volume doesn't have a name on any Thinkpad I have seen so far, Mute and=20
Brightness only on some. But the offset for directly accessing the EC is=20
always the same.

> > led(4) interface for the thinklight (thanks simon)
> > support for reading the fan status and speed
> > support for reading up to 8 thermal sensors
>
> Works great.

Thanks for testing.

Markus

=2D-=20
Markus Brueffer =A0 =A0| GPG-Key: http://people.FreeBSD.org/~markus/markus.=
asc
markus@brueffer.de | FP: 3F9B EBE8 F290 E5CC 1447 8760 D48D 1072 78F8 A8D4
markus@FreeBSD.org | FreeBSD: The Power to Serve!

--nextPart1475104.nWk98nXePS
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)

iD8DBQBCnDuk1I0Qcnj4qNQRAm+pAJ0XyS9gsC+94gnJC0U77dl3KJtx8wCgiieJ
/+8n/GFdlYf3P6hhDPvUHb8=
=1xLV
-----END PGP SIGNATURE-----

--nextPart1475104.nWk98nXePS--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200505311225.40954.markus>