Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Dec 2007 01:32:15 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        cokane@freebsd.org
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/kern kern_module.c src/sys/compat/freebsd32 freebsd32.h freebsd32_misc.c syscalls.master
Message-ID:  <200712110132.17695.jhb@freebsd.org>
In-Reply-To: <47597900.1070006@FreeBSD.org>
References:  <200712062311.lB6NBSBD081134@repoman.freebsd.org> <47597900.1070006@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 07 December 2007 11:46:56 am Coleman Kane wrote:
> John Baldwin wrote:
> > jhb         2007-12-06 23:11:27 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/kern             kern_module.c 
> >     sys/compat/freebsd32 freebsd32.h freebsd32_misc.c 
> >                          syscalls.master 
> >   Log:
> >   Move several data structure definitions out of freebsd32_misc.c and into
> >   freebsd32.h instead.
> >   
> >   MFC after:      1 week
> >   
> >   Revision  Changes    Path
> >   1.7       +56 -0     src/sys/compat/freebsd32/freebsd32.h
> >   1.69      +36 -83    src/sys/compat/freebsd32/freebsd32_misc.c
> >   1.92      +1 -0      src/sys/compat/freebsd32/syscalls.master
> >   1.53      +1 -0      src/sys/kern/kern_module.c
> >   
> This commit now causes the following error when building the kernel on
> my system:
> 
> cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -march=athlon64
> -std=c99  -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes 
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -fformat-extensions -nostdinc  -I. -I/usr/src/sys
> -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
> -include opt_global.h -fno-common -finline-limit=8000 --param
> inline-unit-growth=100 --param large-function-growth=1000 
> -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387
> -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float
> -fno-asynchronous-unwind-tables -ffreestanding -Werror 
> /usr/src/sys/compat/freebsd32/freebsd32_misc.c
> /usr/src/sys/compat/freebsd32/freebsd32_misc.c: In function 'copy_statfs':
> /usr/src/sys/compat/freebsd32/freebsd32_misc.c:153: error: void value
> not ignored as it ought to be
> *** Error code 1
> 
> Looking in src/sys/sys, the offending function call, statfs_scale_blocks
> is defined as void return type in mount.h but a return value is expected
> at this point in freebsd32_misc.c.
> 
> sys/sys/mount.h:void    statfs_scale_blocks(struct statfs *sf, long
> max_size);

Sorry, a part of some statfs 32-bit conversion fixes snuck in.  Should all be 
cleaned up now.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712110132.17695.jhb>