Date: Tue, 29 Dec 2020 21:22:52 -0600 From: Kyle Evans <kevans@freebsd.org> To: Brandon Bergren <bdragon@freebsd.org> Cc: Ryan Libby <rlibby@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Subject: Re: git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11 Message-ID: <CACNAnaGuiqczNFP_gh%2BUiy8RJuxTSX%2BOjoRmeDmaTrOrF5fpow@mail.gmail.com> In-Reply-To: <3b4bc9dc-e868-4171-829e-682d8aab7369@www.fastmail.com> References: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> <CACNAnaEoyoU4Caht1ZceUtSS3CAr-UG7O8amuEu_XpnzKQ8VBA@mail.gmail.com> <CAHgpiFyQrDcNYV-5C6UB0wR6r_bpww4PobMBv_Hq15FT_kfN9Q@mail.gmail.com> <CACNAnaEUCUB7A4AtsCefRpHNjSwkmsiTYvMWsEsYt8XBg3J10w@mail.gmail.com> <CACNAnaEL7cKHD=dFexAuDRomQ6zXKH-Sgb2v3t6Ja6NSnE35%2BQ@mail.gmail.com> <CAHgpiFyJyHrSTfXTvZhkg5uUzbY0Yx_yCY3aL3Fc_Zphj=a%2BbQ@mail.gmail.com> <CACNAnaEJpoSyXOi%2B06ooyEZ6zyQX7tsMUEe%2BeoCkokheNNM6LQ@mail.gmail.com> <3b4bc9dc-e868-4171-829e-682d8aab7369@www.fastmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 29, 2020 at 9:18 PM Brandon Bergren <bdragon@freebsd.org> wrote: > > On Tue, Dec 29, 2020, at 7:21 PM, Kyle Evans wrote: > > > > That is an incredibly good question. The latest build for powerpc > > shows that it did in-fact descend into and build libexec/tftpd/tests > > The tests need to get *built* since they're part of the sets, even if they aren't currently *run* nightly on the CI. > Ryan already pointed out the flaw in my logic (they didn't actually get built, I should have checked libexec/tftpd/tests/Makefile), but the fact that they're not run wasn't significant to this discussion -- the problem observed would have been at compile-time due to an unknown standard or because we weren't specifying the appropriate standard (pre-merge).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaGuiqczNFP_gh%2BUiy8RJuxTSX%2BOjoRmeDmaTrOrF5fpow>