Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Sep 1997 16:57:34 -0600 (MDT)
From:      Nate Williams <nate@mt.sri.com>
To:        John Dyson <dyson@freebsd.org>
Cc:        cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-sys@freebsd.org
Subject:   Re: cvs commit: src/sys/net ppp_deflate.c
Message-ID:  <199709212257.QAA28083@rocky.mt.sri.com>
In-Reply-To: <199709212231.PAA13771@freefall.freebsd.org>
References:  <199709212231.PAA13771@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
John Dyson writes:
> dyson       1997/09/21 15:31:22 PDT
> 
>   Modified files:
>     sys/net              ppp_deflate.c 
>   Log:
>   Remove an unfortunate name clash with the zalloc/zfree routines.  Since the
>   ppp_deflate code uses the names locally - it looses.

Since the ppp code is 'externally' maintained code, did you submit this
patch to the author?  If not, then we have to keep maintaining this
change everytime we update it, which would imply that it would be easier
to change the 'locally' maintained code.

(Also, changing legacy code that uses names recently introduced seems
silly, since the old names already existed.)


Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709212257.QAA28083>