Date: Fri, 07 Apr 2017 22:53:27 +0200 From: Matthew Rezny <rezny@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437953 - in head/lang/beignet: . files Message-ID: <24496938.jsC6qZ9reS@workstation.reztek> In-Reply-To: <a87s-otl5-wny@FreeBSD.org> References: <201704071930.v37JUBGj017948@repo.freebsd.org> <a87s-otl5-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 07 April 2017 22:23:18 Jan Beich wrote:
> Matthew Rezny <rezny@FreeBSD.org> writes:
> > - Enable OpenCL 2.0 on AMD64
>
> Isn't this premature before 1.3.2 or bug 217635 fix?
>
There was no clear answer given in that PR as to whether or not version 1.3.1
addressed the issue, but as I understood it the issue in that PR was caused by
a lack of OpenCL 2.0 so I do not see how enabling it would be premature.
> > +USE_LDCONFIG= ${LOCALBASE}/lib/${PORTNAME}
>
> Why do you need ldconfig hints for dlopen(3)? libcl.so embeds absolute
> paths for libgbe.so and libgbeinterp.so + absolute path via ocl-icd
> config in /usr/local/etc/OpenCL/vendors/intel-beignet.icd
>
> Please, don't turn portlint into a cargo cult.
>
Nothing to do with portlint, just following what is written in the Porter's
Handbook about ports that install shared libraries and USE_LDCONFIG.
> > +LLVMVER= ${MESA_LLVM_VER:U39}
>
> Why not drop LLVMVER variable and use MESA_LLVM_VER directly?
>
> BUILD_DEPENDS= clang${MESA_LLVM_VER}:devel/llvm${MESA_LLVM_VER} \
> [...]
> MESA_LLVM_VER?= 39
Conversely, why do it that way? I see no benefit, just more lines changed.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?24496938.jsC6qZ9reS>