Date: Fri, 29 Sep 2017 21:39:46 +0300 From: Andrej Zverev <az@freebsd.org> To: Luca Pizzamiglio <pizzamig@freebsd.org> Cc: Adam Weinberger <adamw@adamw.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Lars Engels <lme@freebsd.org>, =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= <olivier@freebsd.org> Subject: Re: svn commit: r450810 - head/www/yarn Message-ID: <CAD5bB%2BgAw0zRxF3CgJ%2Bb_4FsP493mj1NW4fW=Mrwr4iOHkJSeg@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
Usually when you broke something you have right to fix it, just with impicit mentor approval (approved by: xxx (mentor)(implicit)). Especially when fix is trivial. On Fri, Sep 29, 2017 at 7:19 PM, Luca Pizzamiglio <pizzamig@freebsd.org> wrote: > Hi Adam, > It's ready to land. I'm only waiting the approval of my mentors: > > https://reviews.freebsd.org/D12542 > > As workaround you can use yarnpkg instead of yarn, it work. > > > On Fri, Sep 29, 2017 at 5:56 PM, Adam Weinberger <adamw@adamw.org> wrote: >>> On 28 Sep, 2017, at 10:27, Adam Weinberger <adamw@adamw.org> wrote: >>> >>>> On 28 Sep, 2017, at 10:21, Adam Weinberger <adamw@adamw.org> wrote: >>>> >>>>> On 28 Sep, 2017, at 3:06, Luca Pizzamiglio <pizzamig@freebsd.org> wrote: >>>>> >>>>> Author: pizzamig >>>>> Date: Thu Sep 28 09:06:27 2017 >>>>> New Revision: 450810 >>>>> URL: https://svnweb.freebsd.org/changeset/ports/450810 >>>>> >>>>> Log: >>>>> www/yarn: Updating to version 1.0.2 >>>>> >>>>> Adopting a more fine grained conflict type >>>>> Fixing a Linux incompatibility >>>>> >>>>> Approved by: olivier (mentor) >>>>> Differential Revision: https://reviews.freebsd.org/D12516 >>>>> >>>>> Modified: >>>>> head/www/yarn/Makefile >>>>> head/www/yarn/distinfo >>>> >>>> Hi Luca, >>>> >>>> Yarn has stopped working for me with this release. This is in a poudriere jail with just yarn installed: >>>> >>>> root@apnoea:/tmp # mkdir foo >>>> root@apnoea:/tmp # cd foo >>>> root@apnoea:/tmp/foo # yarn init >>>> module.js:473 >>>> throw err; >>>> ^ >>>> >>>> Error: Cannot find module '/tmp/lib/node_modules/yarn/bin/yarn.js' >>>> at Function.Module._resolveFilename (module.js:527:15) >>>> at Function.Module._load (module.js:453:25) >>>> at Function.Module.runMain (module.js:665:10) >>>> at startup (bootstrap_node.js:201:16) >>>> at bootstrap_node.js:626:3 >>> >>> Ah, the problem is that REINPLACE_CMD that got removed. It still needs to be there. >>> >> >> Luca, >> >> Are you planning on fixing this? yarn is currently broken. That REINPLACE_CMD needs to be added back in. >> >> # Adam >> >> >> -- >> Adam Weinberger >> adamw@adamw.org >> https://www.adamw.org >> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD5bB%2BgAw0zRxF3CgJ%2Bb_4FsP493mj1NW4fW=Mrwr4iOHkJSeg>