Date: Tue, 30 Jun 2009 07:49:04 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: bz0fbd@zabbadoz.net Cc: svn-src-head@freebsd.org, dfr@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r195181 - in head/sys: nfsclient nfsserver Message-ID: <20090630144904.GA41936@troutmask.apl.washington.edu> In-Reply-To: <20090630051641.T22887@maildrop.int.zabbadoz.net> References: <200906300318.n5U3Ipr4066645@svn.freebsd.org> <20090630051641.T22887@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 30, 2009 at 05:17:48AM +0000, bz0fbd@zabbadoz.net wrote: > On Tue, 30 Jun 2009, John Baldwin wrote: > > >Author: jhb > >Date: Tue Jun 30 03:18:51 2009 > >New Revision: 195181 > >URL: http://svn.freebsd.org/changeset/base/195181 > > > >Log: > > Fix build with NFS_LEGACYRPC enabled after the socket upcall locking > > changes. > > is this really a good idea, considering that NFS_LEGACYRPC is on the > "removal list" for 8.0? Yes. 1) This option definitely worked on April 18th. 2) The option was broken by a commit that was never tested! If anything this should remind committers to either get a code review or test their patch. > > Will it go or will it stay? I thought it was already (partly) gone? > Well, as of June 1, this option was technically gone due to a ill-formed patch. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090630144904.GA41936>