Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 May 2008 19:49:27 +0200
From:      Joerg Sonnenberger <joerg@britannica.bec.de>
To:        cvs-src@freebsd.org
Subject:   Re: cvs commit: src/include stdio.h src/lib/libc/stdio Makefile.inc clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c unlocked.c xprintf.c
Message-ID:  <20080506174927.GE5989@britannica.bec.de>
In-Reply-To: <200805051127.45177.jhb@freebsd.org>
References:  <200805021525.m42FP7GC055065@repoman.freebsd.org> <200805051127.45177.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 05, 2008 at 11:27:44AM -0400, John Baldwin wrote:
> I'll be reverting this shortly.  I had misparsed the maze of stdio headers in 
> glibc and thought that it had a fully opaque FILE.  I will probably not 
> restore unlocked.c though and just leave foo_unlocked() in foo.c.  I will 
> restore all the inlining though since there's not much point in axeing that 
> if we can't make FILE private.

I've seen a bunch of interesting problems when making FILE opaque in
DragonFly. A bunch of programs want to mess with it, e.g. mh is pretty
bad. Even worse is modern gnulib, which also depends on using stdio
internals. I've seen one case where FILE was copied in screen...

Joerg



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080506174927.GE5989>