Date: Mon, 26 Dec 2011 04:56:27 +0800 From: Jan Beich <jbeich@tormail.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/163617: ports-mgmt/portlint: has no clue about dual/multi license defines Message-ID: <1Rev9O-000L7K-Dk@internal.tormail.net> Resent-Message-ID: <201112252100.pBPL0MvJ003100@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 163617
>Category: ports
>Synopsis: ports-mgmt/portlint: has no clue about dual/multi license defines
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Dec 25 21:00:22 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Jan Beich
>Release: FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:
While portlint understands "dual" and "multi" keywords for LICENSE it
fails to recognize expanded defines required by them. As grouping by
newlines seems like a readability improvement when many licenses are
defined portlint should still check the correct order.
>How-To-Repeat:
LICENSE = FOO BAR
LICENSE_COMB = multi
LICENSE_PERMS_FOO = ${_LICENSE_PERMS_DEFAULT}
LICENSE_PERMS_BAR = ${_LICENSE_PERMS_DEFAULT}
LICENSE_TEXT_FOO = blah foo
LICENSE_TEXT_BAR = blah bar
LICENSE_NAME_FOO = foo license
LICENSE_NAME_BAR = bar license
$ portlint
FATAL: Makefile: extra item "LICENSE_PERMS_FOO " placed in the LICENSE section.
FATAL: Makefile: extra item "LICENSE_PERMS_BAR " placed in the LICENSE section.
FATAL: Makefile: extra item "LICENSE_TEXT_FOO " placed in the LICENSE section.
FATAL: Makefile: extra item "LICENSE_TEXT_BAR " placed in the LICENSE section.
FATAL: Makefile: extra item "LICENSE_NAME_FOO" placed in the LICENSE section.
FATAL: Makefile: extra item "LICENSE_NAME_BAR" placed in the LICENSE section.
6 fatal errors and 0 warnings found.
Exit 6
# with a newline after LICENSE_COMB
$ portlint
looks fine.
# after retrofitting into "single" type
$ portlint
FATAL: Makefile: LICENSE_TEXT appears out-of-order.
FATAL: Makefile: LICENSE_NAME appears out-of-order.
FATAL: Makefile: order must be LICENSE/LICENSE_COMB/LICENSE_GROUPS/LICENSE_NAME/LICENSE_TEXT/LICENSE_FILE/LICENSE_PERMS.
3 fatal errors and 0 warnings found.
Exit 3
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1Rev9O-000L7K-Dk>