Date: Fri, 15 Jun 2007 16:52:27 -0400 From: Randall Stewart <rrs@cisco.com> To: John Baldwin <jhb@freebsd.org> Cc: Randall Stewart <rrs@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: src/sys/netinet sctp.h sctp_asconf.c sctp_asconf.h sctp_bsd_addr.c sctp_constants.h sctp_indata.c sctp_input.c sctp_lock_bsd.h sctp_os_bsd.h sctp_output.c sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_sysctl.c sctp_sysctl.h sctp_timer.c sctp_uio.h ... Message-ID: <4672FC0B.1090907@cisco.com> In-Reply-To: <200706151340.29868.jhb@freebsd.org> References: <200706142259.l5EMx4aW053356@repoman.freebsd.org> <20070615022956.GA96741@rot13.obsecurity.org> <4671FA96.1010304@cisco.com> <200706151340.29868.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > > Also, I would use KTR_SCTP and use the same #ifdef above so it is 0 or > KTR_SUBSYS depending on whether or not you want it enabled. > Changing the name around is cosmetic.. and no problem.. The actual ifdef with 0, though.. we have a seperate mask.. since there are 21 or so things that can be logged/traced and they all generate quite a bit of output.. which can be graphed and charted.. along with the usual debugging lot.. Thus there is a seperate mask that turns these on/off.. So .. if for instance you enable KTR_SUBSYS (aka KTR_SCTP) then nothing will come out until you enable the various logging levels in SCTP. The question of if an ifdef is needed.. I did a little performance study yesterday... since originally all the tracepoints were ifdef'd.. so I decided to see if there was any noticable performance penalty for having the additional if(logging mask) CTR6() and I could not measure the difference.. thus all but a few of the ifdef's around these (and thus the options in the build) came out.. R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 <or> 803-317-4952 (cell)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4672FC0B.1090907>