Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Aug 2001 17:43:14 +0300
From:      Giorgos Keramidas <keramida@ceid.upatras.gr>
To:        Dima Dorfman <dima@unixfreak.org>
Cc:        Maxim Sobolev <sobomax@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/dev/md md.c
Message-ID:  <20010827174314.C2081@hades.hell.gr>
In-Reply-To: <20010827133317.4CFF83E31@bazooka.unixfreak.org>; from dima@unixfreak.org on Mon, Aug 27, 2001 at 06:33:12AM -0700
References:  <200108271325.f7RDPmb31236@freefall.freebsd.org> <20010827133317.4CFF83E31@bazooka.unixfreak.org>

next in thread | previous in thread | raw e-mail | index | archive | help
From: Dima Dorfman <dima@unixfreak.org>
Subject: Re: cvs commit: src/sys/dev/md md.c
Date: Mon, Aug 27, 2001 at 06:33:12AM -0700

> Maxim Sobolev <sobomax@FreeBSD.org> wrote:
> > sobomax     2001/08/27 06:25:48 PDT
> > 
> >   Modified files:
> >     sys/dev/md           md.c 
> >   Log:
> >   - On module unload try to detach all configured disks and let unload proceed
> >     if all disks were detached sucessfully;
> 
> I'm not sure this is wise.  More likely than not, trying to unload md
> while there are still disks attached is a mistake on the user's part,
> especially considering that most people aren't going to be loading and
> unloading it on a regular basis.  I understand why this may be useful
> for a developer working on md, but it seems counter-intuitive from a
> regular user's perspective.
> 
> Just my opinion, of course.

This is similar to not having the acd driver close the tray door if
the user requests a mount, when the door is open.  It think that
having things 'happen' behind the user's back is not good.

An error, of "you are still using this thing" would be much better.
But this is only my humble opinion.

-giorgos

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010827174314.C2081>