Date: Wed, 15 May 1996 13:50:26 +0200 From: "Julian H. Stacey" <jhs@freebsd.org> To: Wolfram Schneider <wosch@cs.tu-berlin.de> Cc: current@freebsd.org Subject: Re: diff for current src/usr.sbin/rmt/Makefile Message-ID: <199605151150.NAA06877@vector.jhs.no_domain> In-Reply-To: Your message of "Tue, 14 May 1996 12:25:05 %2B0200." <199605141025.MAA00308@campa.panke.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Reference:
> Reply-to: Wolfram Schneider <wosch@cs.tu-berlin.de>
>
> Julian H. Stacey writes:
> >Here's a diff for src/ tree to prevent a spurious error report in
> >make transcripts. Feel free to abbreviate it :-)
>
> >--- new/src/usr.sbin/rmt/Makefile Mon May 13 14:06:13 1996
> > beforeinstall:
> >! @if test -e ${DESTDIR}/etc/rmt ; then \
> >! echo "Pre-existant ${DESTDIR}/etc/rmt" ; \
> >! ls -l ${DESTDIR}/etc/rmt ; \
> >! else \
> >! echo -n "Creating symbolic link " ; \
> >! echo "${DESTDIR}/etc/rmt --> ${BINDIR}/rmt" ; \
> >! ln -s ${BINDIR}/rmt ${DESTDIR}/etc/rmt ; \
> >! fi
>
> should be
>
> .if exists(${DESTDIR}/etc/rmt)
> @${ECHO} ...
> [...]
> .else
> [...]
> .endif
Probably so, this simpler structure would do, if we're happy to allow
evaluation at Make-invocation-time rather than run time ?
(I have cases in other Makefiles, where I grabbed my syntax from, where
run time is needed, 'cos the dirs. are changing underfoot !)
> And the consensus was that only etc/Makefile change something
> in /etc.
True, so either your fix or my fix should be flipped into
src/etc/Makefile I presume ? Any committers available ?
Julian
--
Julian H. Stacey jhs@freebsd.org http://www.freebsd.org/~jhs/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199605151150.NAA06877>