Date: Mon, 08 Aug 2005 21:39:45 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d cleanvar Message-ID: <42F83391.3080503@FreeBSD.org> In-Reply-To: <200508080946.j789kAS0007023@repoman.freebsd.org> References: <200508080946.j789kAS0007023@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Jakub Dawidek wrote: > pjd 2005-08-08 09:46:10 UTC > > FreeBSD src repository > > Modified files: > etc/rc.d cleanvar > Log: > Back-out previous commit - we need to skip logging socket when we start a > jail and external syslogd is listening in jail's chroot. > > Pointed out by: csjp > > While here, skip also "logpriv" socket. > > Revision Changes Path > 1.10 +3 -0 src/etc/rc.d/cleanvar > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/cleanvar.diff?&r1=1.9&r2=1.10&f=h > Thanks for this change, I agree with it. I would also counsel against deleting things from the rc.d scripts because we "always" do things in a certain order for two reasons. First, we may change the order, and we do. Second, users may change the order. IMO, your observation was valid, but warranted a comment in the script, not removal of the test. hth, Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42F83391.3080503>