Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Aug 2016 11:24:25 -0500
From:      John Marino <freebsd.contact@marino.st>
To:        Wen Heping <wen@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, "B. Estrade" <estrabd@gmail.com>
Subject:   Re: svn commit: r420832 - head/lang/qore
Message-ID:  <624e5728-9366-04e2-c151-d9374c062614@marino.st>
In-Reply-To: <201608250300.u7P30DBt046202@repo.freebsd.org>
References:  <201608250300.u7P30DBt046202@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 8/24/2016 22:00, Wen Heping wrote:
> Author: wen
> Date: Thu Aug 25 03:00:13 2016
> New Revision: 420832
> URL: https://svnweb.freebsd.org/changeset/ports/420832
>
> Log:
>   - Update to 0.8.12
>   - Switch to USE_GITHUB
>   - Add missing BUILD_DEPENDS
>
>   PR:		210447
>   Submitted by:	estrabd@gmail.com(maintainer)
>
> Modified:
>   head/lang/qore/Makefile
>   head/lang/qore/distinfo
>   head/lang/qore/pkg-plist
>
> Modified: head/lang/qore/Makefile
> ==============================================================================
> --- head/lang/qore/Makefile	Thu Aug 25 02:25:58 2016	(r420831)
> +++ head/lang/qore/Makefile	Thu Aug 25 03:00:13 2016	(r420832)
> @@ -1,26 +1,28 @@
>  # $FreeBSD$
>
>  PORTNAME=	qore
> -PORTVERSION=	0.8.11
> +PORTVERSION=	0.8.12
>  CATEGORIES=	lang
> -MASTER_SITES=	SF/qore/qore/${PORTVERSION}/
>
>  MAINTAINER=	estrabd@gmail.com
> -COMMENT=	The Qore Programming Language
> +COMMENT=	Qore Programming Language
>
> -LICENSE=	GPLv2
> -
> -BROKEN_powerpc64=	Does not build
> +LICENSE=	MIT
>
>  LIB_DEPENDS=	libpcre.so:devel/pcre \
>  		libmpfr.so:math/mpfr
>  BUILD_DEPENDS=	${LOCALBASE}/bin/flex:textproc/flex \
> -		${LOCALBASE}/bin/bison:devel/bison
> +		${LOCALBASE}/bin/bison:devel/bison \
> +		${LOCALBASE}/bin/bash:shells/bash
>
> -USES=		gmake iconv libtool pathfix tar:bzip2
> +BROKEN_powerpc64=	Does not build
> +
> +USES=	gmake iconv libtool:build pathfix autoreconf
>  USE_OPENSSL=	yes
>  USE_LDCONFIG=	yes
>  GNU_CONFIGURE=	yes
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	qorelanguage
>
>  CONFIGURE_ENV=	LEX="${LOCALBASE}/bin/flex" PTHREAD_LIBS="-lpthread"
>  CONFIGURE_ARGS=	--disable-debug --disable-static --with-doxygen=no
> @@ -32,10 +34,14 @@ INSTALL_TARGET=	install-strip
>  .include <bsd.port.pre.mk>
>
>  .if ${ARCH} == "powerpc"
> -BROKEN=		Does not compile on powerpc
> +BROKEN=	Does not compile on powerpc
>  .endif
>

Why do have "BROKEN_powerpc64" defined above and '.if ${ARCH} == 
"powerpc"' below?

If you defined "BROKEN_powerpc" then you could get rid of the " .include 
<bsd.port.pre.mk>" and " .include <bsd.port.post.mk>" lines, not to 
mention increasing consistency.

John


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?624e5728-9366-04e2-c151-d9374c062614>