Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 30 Mar 2017 14:04:58 +0000 (UTC)
From:      Jan Beich <jbeich@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org
Subject:   svn commit: r437294 - branches/2017Q1/x11-toolkits/gtk30
Message-ID:  <201703301404.v2UE4w1d097416@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: jbeich
Date: Thu Mar 30 14:04:58 2017
New Revision: 437294
URL: https://svnweb.freebsd.org/changeset/ports/437294

Log:
  MFH: r437293
  
  x11-toolkits/gtk30: prefer warnings over crashes on bad behavior
  
  devel/glib20 and x11-toolkits/gtk20 don't use --disable-debug.
  Neither does gtk3 package on Debian or ArchLinux.
  
  https://bugzilla.mozilla.org/show_bug.cgi?id=1351246#c9
  
    $ cat >a.c
    #include <gdk/gdk.h>
    int main() {
      gdk_get_default_root_window();
      return 0;
    }
  
    $ cc a.c $(pkg-config --cflags --libs gtk+-3.0)
  
    $ ./a.out
    Segmentation fault
  
    vs. (new behavior)
  
    $ ./a.out
    (process:40995): Gdk-CRITICAL **: gdk_screen_get_root_window: assertion 'GDK_IS_SCREEN (screen)' failed
  
  Pointy hat to:	kwm (r372768 broke consistency)
  Approved by:	ports-secteam blanket

Modified:
  branches/2017Q1/x11-toolkits/gtk30/Makefile
Directory Properties:
  branches/2017Q1/   (props changed)

Modified: branches/2017Q1/x11-toolkits/gtk30/Makefile
==============================================================================
--- branches/2017Q1/x11-toolkits/gtk30/Makefile	Thu Mar 30 14:02:58 2017	(r437293)
+++ branches/2017Q1/x11-toolkits/gtk30/Makefile	Thu Mar 30 14:04:58 2017	(r437294)
@@ -5,7 +5,7 @@
 
 PORTNAME=	gtk
 PORTVERSION=	3.18.8
-PORTREVISION?=	3
+PORTREVISION?=	4
 CATEGORIES=	x11-toolkits
 MASTER_SITES=	GNOME/sources/gtk+/${PORTVERSION:C/^([0-9]+\.[0-9]+).*/\1/}
 PKGNAMESUFFIX=	3
@@ -73,7 +73,7 @@ CLOUDPRINT_CONFIGURE_ENABLE=	cloudprint
 CLOUDPRINT_LIB_DEPENDS=	librest-0.7.so:devel/librest \
 			libjson-glib-1.0.so:devel/json-glib
 
-DEBUG_CONFIGURE_ENABLE=debug
+DEBUG_CONFIGURE_ON=	--enable-debug=yes
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|[{]libdir[}]/locale|{datadir}/locale|g' \

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703301404.v2UE4w1d097416>