Date: Tue, 19 Nov 2002 10:46:07 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: RE: PERFORCE change 21259 for review Message-ID: <XFMail.20021119104607.jhb@FreeBSD.org> In-Reply-To: <200211190735.gAJ7ZMDS059613@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19-Nov-2002 Juli Mallett wrote: > http://perforce.freebsd.org/chv.cgi?CH=21259 > > Change 21259 by jmallett@jmallett_luna on 2002/11/18 23:35:03 > > Too much unatomic clutter. Fill in atomic_set_{int,long}, as > they're the basis for most everything else, and other stuff can > be added as it's actually needed. Uh, you do know that atomic_set are actually OR-operations, not assignment. Right? Also, your operations do not look atomic as it seems to be a three instruction sequence of load/modify/store. Imagine an interrupt coming in in between the load and store. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021119104607.jhb>