Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Jun 2015 13:12:45 +1000
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        Jung-uk Kim <jkim@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r389121 - head/archivers/py-lz4
Message-ID:  <5578FCAD.6010201@FreeBSD.org>
In-Reply-To: <201506101814.t5AIESmI078385@svn.freebsd.org>
References:  <201506101814.t5AIESmI078385@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11/06/2015 4:14 AM, Jung-uk Kim wrote:
> Author: jkim
> Date: Wed Jun 10 18:14:28 2015
> New Revision: 389121
> URL: https://svnweb.freebsd.org/changeset/ports/389121
> 
> Log:
>   Fix build dependency.
> 
> Modified:
>   head/archivers/py-lz4/Makefile
> 
> Modified: head/archivers/py-lz4/Makefile
> ==============================================================================
> --- head/archivers/py-lz4/Makefile	Wed Jun 10 18:12:35 2015	(r389120)
> +++ head/archivers/py-lz4/Makefile	Wed Jun 10 18:14:28 2015	(r389121)
> @@ -11,6 +11,8 @@ COMMENT=	Python binding for the LZ4 comp
>  
>  LICENSE=	BSD3CLAUSE
>  
> +BUILD_DEPENDS=	${PYTHON_SITELIBDIR}/nose/__init__.py:${PORTSDIR}/devel/py-nose
> +
>  USE_PYTHON=	autoplist distutils
>  USES=		python
>  
> 

It's *very* likely setup_requires in setup.py adding a build dependency
on nose [1] is a typo, and supposed to be tests_require

I would recommend patching setup.py to say:

setup_requires=["nose>=1.0"],

And submitting the patch upstream in a PR.

[1] https://github.com/steeve/python-lz4/blob/master/setup.py#L34

./koobs



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5578FCAD.6010201>