Date: Mon, 6 Sep 2010 03:40:06 GMT From: Michael Smith <msmith@freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/150235: sysutils/smartmontools build system bug Message-ID: <201009060340.o863e6u0008502@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/150235; it has been noted by GNATS. From: Michael Smith <msmith@freebsd.org> To: Alex Samorukov <samm@os2.kiev.ua> Cc: Doug Barton <dougb@FreeBSD.org>, Garrett Wollman <wollman@FreeBSD.org>, bug-followup@FreeBSD.org Subject: Re: ports/150235: sysutils/smartmontools build system bug Date: Sun, 5 Sep 2010 20:20:45 -0700 --Apple-Mail-6-493367618 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Alex, I haven't maintained the ciss driver in a long time. I'm sure what = you're asking for is reasonable, but you'd need to find out who's = currently looking after it... =3D Mike On Sep 5, 2010, at 3:39 PM, Alex Samorukov wrote: > Hi Michael, >=20 > I am one of the smartmontools developers and smartmontools port = maintainer. Smartmontools project implements ciss device support on a = FreeBSD to obtain smart information from the drives attached to the ciss = controller. To interact with a ciss devices we are using defines from = the cissio.h header. Unfortunately this file is not included in the = /usr/include/sys, and this makes ciss support in smartctl dependable on = installed kernel sources. This makes a problems for some user (see = http://www.freebsd.org/cgi/query-pr.cgi?pr=3D150235). Is it possible to = install this (and probably other headers) file to the /usr/include/sys = on a make install process? This will allow to build fully functional = smartmontools without kernel sources installed. >=20 >=20 > On 09/06/2010 12:22 AM, Philip Paeps wrote: >> On 2010-09-06 00:06:54 (+0200), Alex Samorukov<samm@os2.kiev.ua> = wrote: >> =20 >>> On 09/05/2010 11:44 PM, Doug Barton wrote: >>> =20 >>>> On 09/05/2010 12:28 PM, Alex Samorukov wrote: >>>> =20 >>>>> Your proposed patch will break smartmontools functionality - thats = why >>>>> i`m not able to accept it. >>>>> =20 >>>> It's not at all clear to me why developers@ is cc'ed on these >>>> messages, but since we are ... >>>>=20 >>>> Alex, >>>>=20 >>>> Can you please explain why the change Garrett is suggesting will = break >>>> anything? According to his PR all the headers that smartmontools = needs >>>> are included in /usr/include. Is that not the case? >>>> =20 >>> It is not the case. cciss.cpp from the sources uses = dev/ciss/cissio.h to >>> work with cciss devices on FreeBSD. configure script checks if this = file >>> is exists on the compile time, and if its not - does not compile = cciss >>> support in the smartmontools. >>> If user will try to use cciss driver in this case - smartmontools = will >>> display an error: >>>=20 >>> "CCISS support is not available in this build of smartmontools,\n" >>> "/usr/src/sys/dev/ciss/cissio.h was not available at build = time.\n\n"); >>> =20 >> If that interface is public (which it seems to be, from glancing at = the file), >> the header should be installed in /usr/include/sys. There are = precedents for >> this, see<sys/aac_ioctl.h> and<sys/digiio.h> (and presumably = others). >>=20 >> Any reason not to follow Garrett's suggestion to work with a src = developer, >> perhaps one of the ones listed in the header file you need, to have = it put >> somewhere public? >>=20 >> - Philip >>=20 >> =20 >=20 -- True terror is to wake up one morning and discover that your high school = class is running the country. -- Kurt Vonnegut --Apple-Mail-6-493367618 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; = "><div><br></div><div>Alex,</div><div><br></div><div>I haven't = maintained the ciss driver in a long time. I'm sure what you're = asking for is reasonable, but you'd need to find out who's currently = looking after it...</div><div><br></div><div> =3D = Mike</div><br><div><div>On Sep 5, 2010, at 3:39 PM, Alex Samorukov = wrote:</div><br class=3D"Apple-interchange-newline"><blockquote = type=3D"cite"><div>Hi Michael,<br><br>I am one of the smartmontools = developers and smartmontools port maintainer. Smartmontools = project implements ciss device support on a FreeBSD to obtain smart = information from the drives attached to the ciss controller. To interact = with a ciss devices we are using defines from the cissio.h header. = Unfortunately this file is not included in the /usr/include/sys, and = this makes ciss support in smartctl dependable on installed kernel = sources. This makes a problems for some user (see <a = href=3D"http://www.freebsd.org/cgi/query-pr.cgi?pr=3D150235">http://www.fr= eebsd.org/cgi/query-pr.cgi?pr=3D150235</a>). Is it possible to install = this (and probably other headers) file to the /usr/include/sys on a make = install process? This will allow to build fully functional smartmontools = without kernel sources installed.<br><br><br>On 09/06/2010 12:22 AM, = Philip Paeps wrote:<br><blockquote type=3D"cite">On 2010-09-06 00:06:54 = (+0200), Alex Samorukov<<a = href=3D"mailto:samm@os2.kiev.ua">samm@os2.kiev.ua</a>> = wrote:<br></blockquote><blockquote type=3D"cite"> = <br></blockquote><blockquote type=3D"cite"><blockquote = type=3D"cite">On 09/05/2010 11:44 PM, Doug Barton = wrote:<br></blockquote></blockquote><blockquote type=3D"cite"><blockquote = type=3D"cite"> = <br></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote type=3D"cite">On = 09/05/2010 12:28 PM, Alex Samorukov = wrote:<br></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote type=3D"cite"> = <br></blockquote></blockquote></blockq= uote><blockquote type=3D"cite"><blockquote type=3D"cite"><blockquote = type=3D"cite"><blockquote type=3D"cite">Your proposed patch will break = smartmontools functionality - thats = why<br></blockquote></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote = type=3D"cite"><blockquote type=3D"cite">i`m not able to accept = it.<br></blockquote></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote = type=3D"cite"><blockquote type=3D"cite"> = <br></blockquote></blockqu= ote></blockquote></blockquote><blockquote type=3D"cite"><blockquote = type=3D"cite"><blockquote type=3D"cite">It's not at all clear to me why = developers@ is cc'ed on = these<br></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote = type=3D"cite">messages, but since we are = ...<br></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote = type=3D"cite"><br></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote = type=3D"cite">Alex,<br></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote = type=3D"cite"><br></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote type=3D"cite">Can = you please explain why the change Garrett is suggesting will = break<br></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote = type=3D"cite">anything? According to his PR all the headers that = smartmontools = needs<br></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote type=3D"cite">are = included in /usr/include. Is that not the = case?<br></blockquote></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"><blockquote type=3D"cite"> = <br></blockquote></blockquote></blockq= uote><blockquote type=3D"cite"><blockquote type=3D"cite">It is not the = case. cciss.cpp from the sources uses dev/ciss/cissio.h = to<br></blockquote></blockquote><blockquote type=3D"cite"><blockquote = type=3D"cite">work with cciss devices on FreeBSD. configure script = checks if this file<br></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite">is exists on the compile time, = and if its not - does not compile = cciss<br></blockquote></blockquote><blockquote type=3D"cite"><blockquote = type=3D"cite">support in the = smartmontools.<br></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite">If user will try to use cciss = driver in this case - smartmontools = will<br></blockquote></blockquote><blockquote type=3D"cite"><blockquote = type=3D"cite">display an error:<br></blockquote></blockquote><blockquote = type=3D"cite"><blockquote = type=3D"cite"><br></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite">"CCISS support is not available = in this build of = smartmontools,\n"<br></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite">"/usr/src/sys/dev/ciss/cissio.h = was not available at build = time.\n\n");<br></blockquote></blockquote><blockquote = type=3D"cite"><blockquote type=3D"cite"> = <br></blockquote></blockquote><blockquote = type=3D"cite">If that interface is public (which it seems to be, from = glancing at the file),<br></blockquote><blockquote type=3D"cite">the = header should be installed in /usr/include/sys. There are = precedents for<br></blockquote><blockquote type=3D"cite">this, = see<sys/aac_ioctl.h> and<sys/digiio.h> (and = presumably others).<br></blockquote><blockquote = type=3D"cite"><br></blockquote><blockquote type=3D"cite">Any reason not = to follow Garrett's suggestion to work with a src = developer,<br></blockquote><blockquote type=3D"cite">perhaps one of the = ones listed in the header file you need, to have it = put<br></blockquote><blockquote type=3D"cite">somewhere = public?<br></blockquote><blockquote = type=3D"cite"><br></blockquote><blockquote type=3D"cite"> - = Philip<br></blockquote><blockquote = type=3D"cite"><br></blockquote><blockquote type=3D"cite"> = <br></blockquote><br></div></blockquote></div><br><div> <span class=3D"Apple-style-span" style=3D"border-collapse: separate; = color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; = font-style: normal; font-variant: normal; font-weight: normal; = letter-spacing: normal; line-height: normal; orphans: 2; text-align: = auto; text-indent: 0px; text-transform: none; white-space: normal; = widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; = -webkit-border-vertical-spacing: 0px; = -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: = auto; -webkit-text-stroke-width: 0px; "><span class=3D"Apple-style-span" = style=3D"border-collapse: separate; color: rgb(0, 0, 0); font-family: = Helvetica; font-size: 12px; font-style: normal; font-variant: normal; = font-weight: normal; letter-spacing: normal; line-height: normal; = orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; = widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; = -webkit-border-vertical-spacing: 0px; = -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: = auto; -webkit-text-stroke-width: 0px; "><div style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; -webkit-line-break: = after-white-space; "><span class=3D"Apple-style-span" = style=3D"border-collapse: separate; color: rgb(0, 0, 0); font-family: = Helvetica; font-size: 12px; font-style: normal; font-variant: normal; = font-weight: normal; letter-spacing: normal; line-height: normal; = orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; = widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; = -webkit-border-vertical-spacing: 0px; = -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: = auto; -webkit-text-stroke-width: 0px; "><div style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; -webkit-line-break: = after-white-space; "><span class=3D"Apple-style-span" = style=3D"border-collapse: separate; color: rgb(0, 0, 0); font-family: = Helvetica; font-size: 12px; font-style: normal; font-variant: normal; = font-weight: normal; letter-spacing: normal; line-height: normal; = orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; = widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; = -webkit-border-vertical-spacing: 0px; = -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: = auto; -webkit-text-stroke-width: 0px; "><div style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; -webkit-line-break: = after-white-space; "><span class=3D"Apple-style-span" = style=3D"border-collapse: separate; color: rgb(0, 0, 0); font-family: = Helvetica; font-size: 12px; font-style: normal; font-variant: normal; = font-weight: normal; letter-spacing: normal; line-height: normal; = orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; = widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; = -webkit-border-vertical-spacing: 0px; = -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: = auto; -webkit-text-stroke-width: 0px; "><div style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; -webkit-line-break: = after-white-space; "><div><font class=3D"Apple-style-span" = size=3D"2"><span class=3D"Apple-style-span" style=3D"font-size: 10px; = "><i>--</i></span></font></div><div><font class=3D"Apple-style-span" = size=3D"2"><span class=3D"Apple-style-span" style=3D"font-size: 10px; = "><i>True terror is to wake up one morning and discover that your high = school class is running the country. --<span = class=3D"Apple-converted-space"> </span></i>Kurt = Vonnegut</span></font></div><div><br></div></div></span><br = class=3D"Apple-interchange-newline"></div></span><br = class=3D"Apple-interchange-newline"></div></span><br = class=3D"Apple-interchange-newline"></div></span><br = class=3D"Apple-interchange-newline"></span><br = class=3D"Apple-interchange-newline"> </div> <br></body></html>= --Apple-Mail-6-493367618--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009060340.o863e6u0008502>