Date: Fri, 1 Jun 2018 20:07:43 -0400 From: Allan Jude <allanjude@freebsd.org> To: freebsd-hackers@freebsd.org Subject: Re: PRs are being closed for bogus reasons :-( Message-ID: <1e0e3db1-f1d6-b225-df3e-182c0ed71818@freebsd.org> In-Reply-To: <BF6F6F01-70A9-4BDF-BB29-F76F43AB57AC@sigsegv.be> References: <CAA3ZYrDE1qN36jkg6bfTuUQL-Ko01UhVa=i%2BJ7t7AfN4hdBDMQ@mail.gmail.com> <CANCZdfovyg61=b0-60ZD426Z=774Wxm9hJxZ=bSqReW_fD4DoA@mail.gmail.com> <1407.1527801278@critter.freebsd.dk> <DED226CC-1D10-48A7-A1A8-0021DEA727A2@gid.co.uk> <CANCZdfrG_=D466HygdFv9%2B%2BZcN26NNN%2BnvE2NH3KAQWfyRCyqw@mail.gmail.com> <D83255D1-CC26-4536-A42E-5E742941FC05@gid.co.uk> <CANCZdfp9vaNgQew4AON30em4oEUKtR8QJ6Y5=1YVtzBba-1vtA@mail.gmail.com> <BF6F6F01-70A9-4BDF-BB29-F76F43AB57AC@sigsegv.be>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TT1I4uakRtLBT0fAdgg6wgJKjxiH7LCsH Content-Type: multipart/mixed; boundary="Rl5PYaMOEqQ1WgxhNtmAK3BaQQSapgfyC"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: freebsd-hackers@freebsd.org Message-ID: <1e0e3db1-f1d6-b225-df3e-182c0ed71818@freebsd.org> Subject: Re: PRs are being closed for bogus reasons :-( References: <CAA3ZYrDE1qN36jkg6bfTuUQL-Ko01UhVa=i+J7t7AfN4hdBDMQ@mail.gmail.com> <CANCZdfovyg61=b0-60ZD426Z=774Wxm9hJxZ=bSqReW_fD4DoA@mail.gmail.com> <1407.1527801278@critter.freebsd.dk> <DED226CC-1D10-48A7-A1A8-0021DEA727A2@gid.co.uk> <CANCZdfrG_=D466HygdFv9++ZcN26NNN+nvE2NH3KAQWfyRCyqw@mail.gmail.com> <D83255D1-CC26-4536-A42E-5E742941FC05@gid.co.uk> <CANCZdfp9vaNgQew4AON30em4oEUKtR8QJ6Y5=1YVtzBba-1vtA@mail.gmail.com> <BF6F6F01-70A9-4BDF-BB29-F76F43AB57AC@sigsegv.be> In-Reply-To: <BF6F6F01-70A9-4BDF-BB29-F76F43AB57AC@sigsegv.be> --Rl5PYaMOEqQ1WgxhNtmAK3BaQQSapgfyC Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-06-01 11:27, Kristof Provost wrote: > On 1 Jun 2018, at 17:09, Warner Losh wrote: >> On Fri, Jun 1, 2018 at 8:53 AM, <rb@gid.co.uk> wrote: >>>> On 1 Jun 2018, at 15:41, Warner Losh <imp@bsdimp.com> wrote: >>> The sad truth is that only about 10-15% of them have comitable >>> patches in >>> them when submitted. And that number decays over time as things age i= n >>> bugzilla. [etc] >>> >>> Sure. But the best a non-comitter can do is to supply a patch tested >>> against HEAD. If the patch rots because it hasn=E2=80=99t been commit= ted six >>> months >>> down the line it=E2=80=99s not my fault. >>> >> >> Well, not quite true. I've had several people send me pointers to bugs= >> over >> the years and engage me when I tell them that the patch isn't quite >> right. >> That conversation is easier, to my mind, in Phabricator, though. >> There's no >> substitute for making good connections and motivating volunteers to >> want to >> help you. That gives much better results than filing and forgetting an= d >> hoping for the best. As a committer, I find it a low return on investm= ent >> to go looking at random PRs. I find it a much higher return on investm= ent >> when I have a history with someone (even a short one). >> >> Fixing this broken state of affairs is not going to be easy... >> > This is also true for bug reports with no patches attached to them. > Bug reports with more information, more reports from people affected by= the > same bug, simplified test cases, follow-up with confirmation that other= > versions are affected too and so on are more likely to attract attentio= n. >=20 > For better or worse, the fact is that both patches and bug reports fare= > better > if their submitter actively advocates for them. >=20 > I don=E2=80=99t mean to suggest that it is somehow the fault of the sub= mitter if > bugs > don=E2=80=99t get fixed. Instead I want to point at this as something p= eople can > do to > help, even if they don=E2=80=99t have commit access, or even if they do= n't know > how to > read or write code. >=20 > Regards, > Kristof > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.o= rg" This point was well made by one of Ed Maste's interns for the spring semester. A good glimpse into the 'new contributor' experience: https://www.freebsdfoundation.org/blog/guest-blog-what-i-learned-during-m= y-freebsd-internship/ --=20 Allan Jude --Rl5PYaMOEqQ1WgxhNtmAK3BaQQSapgfyC-- --TT1I4uakRtLBT0fAdgg6wgJKjxiH7LCsH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJbEd/SAAoJEBmVNT4SmAt+0I4QAI5X1eguhlwDR4U4/ua2Y6oQ hf1WYAYL/jsORd/kh2XkRW+UlogTI/XeKbjN5ZmwK2IYepcnB/wqfU6kyuQSloHX t4ktIJQS4iXVsLN4NS11uWhOSqAw6cGfznncZHTQaYS5Sc7dBQmUuH4aVqXpYepW Ql1N6ZLuRQCuaxoVwOdqwzdEitzwEcf0rDBsvgfDjdytoVEWR33euVTxo2f3ypoq kV5br0rcA4lCfl3NkcA0rLcsnDm4/6rBwqfbFQg5+LFZ+teLgvxEeILUD59qWL63 HRiCvb2c5LCpvwMVPhYmgTFeu19K6yCjHnxWt9hVP3Tb4eu34qVMFOmtA+x7y6BZ zY61x79qTJ91wmrKvgtaAO1F4+XSzFHCny4P3sXZmChiWDp5hxnfMFu1pumtss8K tV7B/o0KPl6tre0ISpYZnRCB9beJiBH0EWwXWhz7r8KlM0DzQEZ5Y78xNmJ9x1kW UsJ+iu8obbjyn3MaxHE2LWkadv6I5BppB69EBP63ZHUtFogrz9Fb3++8Aew/6tpV 6BxCqSklnYR8EEp2kBBacS9vge0Y05+aXD09nu5U+dS/+WBZt7zTD/dMTriTXSE8 SdmoNLmnkANeHZ6bQnv58oxgmvbepxPur/733AyY1C45B8PdFE6SF6Wcl8l+x2S9 YV2LSb9AK4cuvylkNUPV =lGOw -----END PGP SIGNATURE----- --TT1I4uakRtLBT0fAdgg6wgJKjxiH7LCsH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1e0e3db1-f1d6-b225-df3e-182c0ed71818>