Date: Tue, 7 Jun 2005 02:02:15 +0100 From: Bruce M Simpson <bms@spc.org> To: =?iso-8859-1?Q?S=F8ren?= Schmidt <sos@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Nate Lawson <nate@root.org> Subject: Re: cvs commit: src/sys/dev/ata ata-raid.c Message-ID: <20050607010215.GB821@empiric.icir.org> In-Reply-To: <8F5450B3-BEB2-4FAC-A8C4-E64D626EA1C6@FreeBSD.org> References: <20050606154917.7AEE716A42B@hub.freebsd.org> <42A490F2.4010705@root.org> <8F5450B3-BEB2-4FAC-A8C4-E64D626EA1C6@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 06, 2005 at 08:37:09PM +0200, Søren Schmidt wrote:
> >>+ printf("magic_2 0x%016llx\n",(unsigned long long)
> >>meta->magic_2);
> >
> >I think %jx is preferred to a cast.
>
> I think I prefer the style of the rest of ATA.
I think I prefer portable code :-(
BMS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050607010215.GB821>