Date: Fri, 20 Mar 2015 15:40:16 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org>, Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381760 - in head/x11-fonts/sourcesanspro-ttf: . files Message-ID: <550C85B0.5050902@FreeBSD.org> In-Reply-To: <550C6B34.8020401@FreeBSD.org> References: <201503201823.t2KIN32I080448@svn.freebsd.org> <550C6655.5010802@FreeBSD.org> <20150320183524.GD87678@ivaldir.etoilebsd.net> <9BE33FCA-5C2F-4FEA-9B3A-5D9DB6632635@adamw.org> <550C6B34.8020401@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--6VXAHgrEG18h8UkDbjDdwfH7OeP86vbko
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 3/20/2015 1:47 PM, Bryan Drewery wrote:
> On 3/20/2015 1:43 PM, Adam Weinberger wrote:
>>
>>> On 20 Mar, 2015, at 12:35, Baptiste Daroussin <bapt@FreeBSD.org> wrot=
e:
>>>
>>> On Fri, Mar 20, 2015 at 01:26:29PM -0500, Bryan Drewery wrote:
>>>> On 3/20/2015 1:23 PM, Baptiste Daroussin wrote:
>>>>> +WRKSRC=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME:S,/,-,}
>>>>
>>>> I think we should put this globally in this 1 line:
>>>>
>>>> bsd.port.mk
>>>> 1561 . if defined(GH_TAGNAME)
>>>> 1562 WRKSRC?=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME}
>>>>
>>>>
>>>> After https://reviews.freebsd.org/D2103 is resolved I will fix that.=
>>>
>>> Almost in this case upstream decided to put a / in the TAGNAME which =
is ... well
>>> ... :)
>>
>> It would be so unbelievably nice if we had a way to just specify the d=
estination filename, using fetch -o. All the bizarre names that files are=
published as, the unversioned tarballs, the documentation files labelled=
Documentation.pdf, and the fallout from changes like this.... we could m=
ake our lives so much easier with a DISTFILE_DEST variable.
>>
>> # Adam
>>
>>
>=20
> For USE_GITHUB that is exactly what DISTNAME is. You can name it
> whatever you want.
>=20
> As for your other examples I agree. I'll look into that!
>=20
Thinking about it a bit more I don't have time to implement this today
or soon.
DISTFILES would need a syntax to specify an output filename. The
do-fetch and do-checksum targets in bsd.port.mk would need a lot of
rework. They are very risky to touch and hard to maintain as is.
Ideas for a DISTFILES format?
--=20
Regards,
Bryan Drewery
--6VXAHgrEG18h8UkDbjDdwfH7OeP86vbko
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJVDIWwAAoJEDXXcbtuRpfPU9YIAK04Gn0HzccGVySKcYTUpZRI
ZbAUnqq6yzSnT3PLF74bQaW4zRZLKsNVhjgSONbohul+aVOnvX+FPNSHQrostMmK
mOgBord7uD5IGi32wFQIin5SCNi/fJlNU0O9yi9x+GDELtXoaoif4jIApurxSrQT
2idJPb/i9JsgoLMi610/Rgf6F37nVx13GgcbcQYjSv5Z7cOjc2paCccaPKP2Iqm+
RovIk+4muAc2lGERfh3kMaejXx8OVBoHXYIXbtDjWRqttl9cGblZPIZcSVpMW3Ao
8r0kE0aHiS5SHYf5sclmXujsmMxeoZcQe2lFr8dYHqzcgTb9ZnXv6wXLqGcKLRg=
=U0bT
-----END PGP SIGNATURE-----
--6VXAHgrEG18h8UkDbjDdwfH7OeP86vbko--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?550C85B0.5050902>