Date: Sat, 26 Jun 2004 20:35:56 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Alexander Kabaev <kan@FreeBSD.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_radius pam_radius.c Message-ID: <20040627033556.GC43829@dragon.nuxi.com> In-Reply-To: <20040625123827.GA55913@freefall.freebsd.org> References: <200406250154.i5P1sQcp072094@repoman.freebsd.org> <xzp659g0ywd.fsf@dwp.des.no> <20040625120329.GB37003@ip.net.ua> <xzp1xk325pg.fsf@dwp.des.no> <20040625123827.GA55913@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 25, 2004 at 12:38:27PM +0000, Alexander Kabaev wrote: > On Fri, Jun 25, 2004 at 02:16:27PM +0200, Dag-Erling Sm?rgrav wrote: > > Ruslan Ermilov <ru@FreeBSD.org> writes: > > > On Fri, Jun 25, 2004 at 11:28:50AM +0200, Dag-Erling Sm?rgrav wrote: > > > > Alexander Kabaev <kan@FreeBSD.org> writes: > > > > > Log: > > > > > Remove the use of cast as lvalue. > > > > This trades one style bug for another (missing space before *), breaks > > > > the build on 64-bit platforms, and violates maintainership. > > > Ah, so this commit is responsible for a cross-build breakage... > > > > No, this one currently only breaks Alpha because we apparently don't > > enforce alignment requirements on other platforms. > > > It definitely worked for amd64 world, which I guess does not have such > strict alignment requirements. Not at all -- AMD64 is an x86 platform first and fore most. That means no traps or exceptions on misalignments like for Alpha and other RISC platforms. There is of course a performance degradation on AMD64, but its the same as misalignments for x86 32-bit. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040627033556.GC43829>