Date: Fri, 20 Apr 2018 11:50:18 -0700 From: Conrad Meyer <cem@freebsd.org> To: Rick Macklem <rmacklem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332813 - head/sys/fs/nfsclient Message-ID: <CAG6CVpUGcJFZcWFcu0iJYvAkX0uftso8=fr3TfjrhVeqnnY3_Q@mail.gmail.com> In-Reply-To: <201804201138.w3KBcTou070611@repo.freebsd.org> References: <201804201138.w3KBcTou070611@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 20, 2018 at 4:38 AM, Rick Macklem <rmacklem@freebsd.org> wrote: > Author: rmacklem > Date: Fri Apr 20 11:38:29 2018 > New Revision: 332813 > URL: https://svnweb.freebsd.org/changeset/base/332813 > > Log: > Fix use of pointer after being set NULL. > > Using a pointer after setting it NULL is probably not a good plan. > Spotted by inspection during changes for Flexible File Layout Ioerr handling. > This code path obviously isn't normally executed. This is definitely the kind of thing that Coverity can catch. I would strongly encourage you to take a look at the Coverity scan output for nfsclient. There are a bunch of reports, many of which I have confirmed are valid. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUGcJFZcWFcu0iJYvAkX0uftso8=fr3TfjrhVeqnnY3_Q>