Date: Tue, 2 Sep 2003 20:33:15 -0700 (PDT) From: Marcel Moolenaar <marcel@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 37416 for review Message-ID: <200309030333.h833XFYh037631@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=37416 Change 37416 by marcel@marcel_nfs on 2003/09/02 20:33:09 o Remove inclusion of <sys/systm.h>. It was needed for uart_debug(), which got axed yesterday. o Remove sc_xonxoff, which got added yesterday. We're not going to support XON/XOFF flow control with hardware support. It's way too complicated to do it right and we already have the support in the tty layer. o Replace sc_rtscts with sc_hwiflow and sc_hwoflow. We'd like to take advantage of hardware flow control, even if only input or output flow control works for us. If we have a single flag, then it's a both or neither situation. Also, since we seperate flags for input and output flow control in the termios structure, it makes sense to keep them seperated as long as possible. Affected files ... .. //depot/projects/uart/dev/uart/uart_bus.h#24 edit Differences ... ==== //depot/projects/uart/dev/uart/uart_bus.h#24 (text+ko) ==== @@ -29,8 +29,6 @@ #ifndef _DEV_UART_BUS_H_ #define _DEV_UART_BUS_H_ -#include <sys/systm.h> - /* Drain and flush targets. */ #define UART_DRAIN_RECEIVER 0x0001 #define UART_DRAIN_TRANSMITTER 0x0002 @@ -111,12 +109,12 @@ int sc_callout:1; /* This UART is opened for callout. */ int sc_fastintr:1; /* This UART uses fast interrupts. */ int sc_hasfifo:1; /* This UART has FIFOs. */ + int sc_hwiflow:1; /* This UART has HW input flow ctl. */ + int sc_hwoflow:1; /* This UART has HW output flow ctl. */ int sc_leaving:1; /* This UART is going away. */ int sc_opened:1; /* This UART is open for business. */ int sc_polled:1; /* This UART has no interrupts. */ - int sc_rtscts:1; /* This UART can do HW flow control. */ int sc_txbusy:1; /* This UART is transmitting. */ - int sc_xonxoff:1; /* This UART can do SW flow control. */ struct uart_devinfo *sc_sysdev; /* System device (or NULL). */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200309030333.h833XFYh037631>