Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 07 Feb 2015 00:37:04 +0100
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Rene Ladan <rene@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r378563 - in head/www/chromium: . files
Message-ID:  <lhka-ipcv-wny@vfemail.net>
In-Reply-To: <201502062228.t16MSqq8072725@svn.freebsd.org> (Rene Ladan's message of "Fri, 6 Feb 2015 22:28:52 %2B0000 (UTC)")
References:  <201502062228.t16MSqq8072725@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain

Rene Ladan <rene@FreeBSD.org> writes:

>  +#elif V8_OS_FREEBSD
> ++#  ifdef __DragonFly__
> ++  return static_cast<int>(lwp_gettid());

Ironically, V8_OS_DRAGONFLYBSD is ignored with USES=alias. Try the
following to make upstreaming easier

  #elif V8_OS_DRAGONFLYBSD || defined(__DragonFly__)
    return static_cast<int>(lwp_gettid());
  #elif V8_OS_FREEBSD
  ...

> ++#  elif __FreeBSD_version__ < 900031

Have you made sure __FreeBSD_version__ is defined?

> ++  return 0; /* ! */

Maybe replace with

    #include <sys/thr.h>
    ...
    long lwpid;
    thr_self(&lwpid);
    return static_cast<int>(lwpid);

> ++#  else

Bonus for upstream

  #if defined(OS_NETBSD)
  #include <lwp.h>
  #endif
  ...
  #elif V8_OS_NETBSD
    return static_cast<int>(_lwp_self());
  #else

>  +  return static_cast<int>(pthread_getthreadid_np());
> ++#  endif
>   #else
>     return static_cast<int>(pthread_self());
>   #endif

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQF8BAEBCgBmBQJU1VAgXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bZTUH/Rf4AcorWCVE0tQ3Pu1qs8qD
YTxr5MPuMM72RYQhc/Ls4D9M4jZOux6yDGW0UmsoM4qpazYUseDrkKupO39baRaG
f9p+NvHqZna3MWpzAGKRsoBZIz2RZFC+NMC9+LAkYhHsXUrxHh1Dpj0EGz7rHhfW
b6pxdgV3P4KgImv1Eu4xhyBz/0t59lgqMBnUK9/hoyJki7LB2NrcpSPAXShPMVww
b1mZaBInpOYy8C2CJIpNTplCPOVZZ+NIcjBTV6zIu2N7rVp1FLvfKSzh/lEuViIh
Y0BRsTWeJvcgXHeuBXlfEUzC3qeyRxp4UOdiuY4DYPpcn3u8i3GDUs3dWc1txrg=
=iLcu
-----END PGP SIGNATURE-----
--=-=-=--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?lhka-ipcv-wny>