Date: Fri, 24 May 2019 12:58:13 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Kubilay Kocak <koobs@freebsd.org> Cc: Rene Ladan <rene@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r502461 - in head/www/chromium: . files Message-ID: <20190524125813.GA80150@FreeBSD.org> In-Reply-To: <03e929e1-4f54-3017-1629-3965dd63ee17@FreeBSD.org> References: <201905241234.x4OCYwWJ055964@repo.freebsd.org> <20190524124243.GA55965@FreeBSD.org> <03e929e1-4f54-3017-1629-3965dd63ee17@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 24, 2019 at 10:47:36PM +1000, Kubilay Kocak wrote: > On 24/05/2019 10:42 pm, Alexey Dokuchaev wrote: > > On Fri, May 24, 2019 at 12:34:58PM +0000, Rene Ladan wrote: > >> New Revision: 502461 > >> URL: https://svnweb.freebsd.org/changeset/ports/502461 > >> > >> Log: > >> www/chromium: update to 74.0.3729.157 > >> > >> Submitted by: Matthias Wolf via GitHub (#150 #151) > >> MFH: 2019Q2 > > > > Many patches that were modified only changed in metainfo or context > > (+/- few lines) and thus just cluttered this very noisy commit for > > no real benefit. > > > > Please try to exclude them from the commit batch next time to reduce > > amount of repochurn. > > fwiw, makepatch is now ignoring metadata only changes. Not sure when > this new feature crept in. Technically, line changes are not strictly metadata only changes, and the old patch might not apply. However, most of the times new address is within a few lines, and patch(1) can easily find the right context even when address is off by several hundred lines. It might not be very important for small commit batch, but for large commits, minizing the diff becomes essential since it greatly helps to understand, rollback, or/and replay changes (especially if there is some local work in place, e.g. some custom patches). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190524125813.GA80150>