Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Jul 2006 16:56:08 GMT
From:      "Wojciech A. Koszek" <wkoszek@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 100901 for review
Message-ID:  <200607071656.k67Gu817050281@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=100901

Change 100901 by wkoszek@wkoszek_laptop on 2006/07/07 16:55:39

	After Alexander's changes, I can uncomment this piece in vfs_bio.c
	because we have correct definitions for popular data types.

Affected files ...

.. //depot/projects/mips2/src/sys/kern/vfs_bio.c#3 edit

Differences ...

==== //depot/projects/mips2/src/sys/kern/vfs_bio.c#3 (text+ko) ====

@@ -3154,7 +3154,6 @@
  * XXXMIPS: This was the easiest way to move on.
  * Leave it for later, since kernel at this stage won't probably boot.
  */
-#if 0
 	KASSERT(BUF_REFCNT(bp) > 0, ("biodone: bp %p not busy %d", bp,
 	    BUF_REFCNT(bp)));
 
@@ -3249,12 +3248,11 @@
 			 * have not set the page busy flag correctly!!!
 			 */
 			if (m->busy == 0) {
-				uint32_t mask = 0xffffffff;
 				printf("biodone: page busy < 0, "
 				    "pindex: %d, foff: 0x(%x,%x), "
 				    "resid: %d, index: %d\n",
 				    (int) m->pindex, (int)(foff >> 32),
-						(int) foff & mask, resid, i);
+						(int) foff & 0xffffffff, resid, i);
 				if (!vn_isdisk(vp, NULL))
 					printf(" iosize: %jd, lblkno: %jd, flags: 0x%x, npages: %d\n",
 					    (intmax_t)bp->b_vp->v_mount->mnt_stat.f_iosize,
@@ -3292,7 +3290,6 @@
 			bqrelse(bp);
 	} else
 		bdone(bp);
-#endif
 }
 
 /*
@@ -3610,7 +3607,6 @@
 	 * XXXMIPS: Hack this part to make it working on MIPS.
 	 * Leave it for later.
 	 */
-#if 0
 	vm_offset_t pg;
 	vm_page_t p;
 	int index;
@@ -3644,7 +3640,6 @@
 	}
 	VM_OBJECT_UNLOCK(kernel_object);
 	bp->b_npages = index;
-#endif
 }
 
 /* Return pages associated with this buf to the vm system */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607071656.k67Gu817050281>