Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Jun 2018 13:07:40 +0000
From:      bugzilla-noreply@freebsd.org
To:        gnome@FreeBSD.org
Subject:   [Bug 220597] deskutils/gucharmap: does not compile
Message-ID:  <bug-220597-6497-IxW98ibDkp@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-220597-6497@https.bugs.freebsd.org/bugzilla/>
References:  <bug-220597-6497@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220597

--- Comment #57 from Ting-Wei Lan <lantw44@gmail.com> ---
Comment on attachment 194665
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D194665
svn-diff-full-gucharmapt_v2

>Index: Makefile
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>--- Makefile	(revision 473314)
>+++ Makefile	(working copy)
>@@ -2,7 +2,7 @@
> # $FreeBSD$
>=20
> PORTNAME=3D	gucharmap
>-PORTVERSION=3D	9.0.4
>+PORTVERSION=3D	10.0.4

The latest gucharmap release is 11.0.1. The version number of gucharmap is
intended to match the version number of Unicode. Since our UCD has version =
11,
it will be better to update to gucharmap 11 instead of backporting patches =
from
11 to 10.

However, gucharmap developers haven't published source tarballs for version=
 11
because they want to find a way for GitLab to upload tarballs automatically:
https://gitlab.gnome.org/GNOME/gucharmap/issues/3. We may have to switch to
USE_GITLAB in the mean time and this will require autoreconf.

> CATEGORIES=3D	deskutils gnome
> MASTER_SITES=3D	GNOME
> DIST_SUBDIR=3D	gnome3
>@@ -15,12 +15,13 @@
>=20
> BUILD_DEPENDS=3D	itstool:textproc/itstool \
> 		UCD>=3D0:textproc/UCD
>+LIB_DEPENDS+=3D	libfreetype.so:print/freetype2

This is fine. The reason gucharmap links directly to freetype2 is that the
upstream developer doesn't want to see color emoji in a character map
application.

>=20
> PORTSCOUT=3D	limitw:1,even
>=20
>-USES=3D		desktop-file-utils gmake gnome libtool localbase \
>+USES=3D		desktop-file-utils gettext gmake gnome libtool localbase \
> 		pathfix pkgconfig tar:xz
>-USE_GNOME=3D	cairo gdkpixbuf2 gtk30 intltool introspection:build
>+USE_GNOME=3D	cairo gdkpixbuf2 gtk30 intltool intlhack introspection:build

Is intlhack still needed? Since using GitLab tarballs will require running
autoreconf, hacks on generated files will not be needed.

> GNU_CONFIGURE=3D	yes
> CONFIGURE_ARGS=3D	--with-unicode-data=3D${LOCALBASE}/share/unicode/ucd/
> USE_LDCONFIG=3D	yes
>@@ -28,11 +29,14 @@
>=20
> GLIB_SCHEMAS=3D	org.gnome.Charmap.enums.xml \
> 		org.gnome.Charmap.gschema.xml
>+MAKE_ARGS+=3D	ACLOCAL=3D"${TRUE}" AUTOCONF=3D"${TRUE}" AUTOHEADER=3D"${TR=
UE}" \
>+		AUTOMAKE=3D"${TRUE}"

Please remove this. This debugging code should not appear in the ports tree.

>=20
>-OPTIONS_SUB=3D	yes
>-OPTIONS_DEFINE=3D	NLS
>+#OPTIONS_SUB=3D	yes
>+#OPTIONS_DEFINE=3D	NLS
>=20
>-NLS_USES=3D	gettext
>-NLS_CONFIGURE_ENABLE=3D	nls
>+#NLS_USES=3D	gettext-tools
>+#NLS_CONFIGURE_ENABLE=3D	nls
>+#NLS_CONFIGURE_OFF=3D	--disable-nls

If it isn't going to work, can you simply remove them instead of commenting
out?

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220597-6497-IxW98ibDkp>