Date: Sat, 13 Jun 2015 19:30:36 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org, "src-committers@freebsd.org" <src-committers@freebsd.org>, Allan Jude <allanjude@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com> Subject: Re: svn commit: r284336 - head/sys/dev/acpi_support Message-ID: <CAOfEmZhjMhje7CwjAKDLgD-QUV5ksV17RNaKpW24uHcsDa3Hdg@mail.gmail.com> In-Reply-To: <CAGHfRMBuRA2w6y8rG%2BOBEK8qW1e8BSbXyrULvBpgMc=_1fnXKg@mail.gmail.com> References: <201506130555.t5D5tQij003839@svn.freebsd.org> <20150613073746.GJ2080@kib.kiev.ua> <CAGHfRMBuRA2w6y8rG%2BOBEK8qW1e8BSbXyrULvBpgMc=_1fnXKg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
+1. On Jun 13, 2015 3:42 PM, "NGie Cooper" <yaneurabeya@gmail.com> wrote: > On Sat, Jun 13, 2015 at 12:37 AM, Konstantin Belousov > <kostikbel@gmail.com> wrote: > > On Sat, Jun 13, 2015 at 05:55:26AM +0000, Allan Jude wrote: > >> Author: allanjude (doc committer) > >> Date: Sat Jun 13 05:55:26 2015 > >> New Revision: 284336 > >> URL: https://svnweb.freebsd.org/changeset/base/284336 > >> > >> Log: > >> acpi_ibm.ko panics if SMBIOS information is not available > >> > >> Add a check for NULL before strcmp on smbios information incase it is > not populated > >> > >> Differential Revision: https://reviews.freebsd.org/D2750 > >> Reviewed by: ngie, jhb > >> Approved by: rpaulo > >> Sponsored by: ScaleEngine Inc. > >> > >> Modified: > >> head/sys/dev/acpi_support/acpi_ibm.c > >> > >> Modified: head/sys/dev/acpi_support/acpi_ibm.c > >> > ============================================================================== > >> --- head/sys/dev/acpi_support/acpi_ibm.c Sat Jun 13 01:28:19 2015 > (r284335) > >> +++ head/sys/dev/acpi_support/acpi_ibm.c Sat Jun 13 05:55:26 2015 > (r284336) > >> @@ -485,6 +485,9 @@ acpi_ibm_attach(device_t dev) > >> /* Enable per-model events. */ > >> maker = kern_getenv("smbios.system.maker"); > >> product = kern_getenv("smbios.system.product"); > >> + if (maker != NULL && product != NULL) > >> + goto nosmbios; > > This looks reversed. I would expect the condition to be > > if (maker == NULL || product == NULL) > > goto ...; > > +1 > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZhjMhje7CwjAKDLgD-QUV5ksV17RNaKpW24uHcsDa3Hdg>