Date: Sat, 19 Mar 2005 12:39:59 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: David Xu <davidxu@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_thread.c Message-ID: <23463.1111232399@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 19 Mar 2005 19:16:31 %2B0800." <423C0A0F.6090409@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <423C0A0F.6090409@freebsd.org>, David Xu writes: >Poul-Henning Kamp wrote: > >>phk 2005-03-19 08:22:13 UTC >> >> FreeBSD src repository >> >> Sleeping is not allowed in uma->fini >> >I have not tested if this change will hurt libpthread performance, >but it is obvious that benifit of uma cache will be reduced by >this change. I am aware of that and I don't like it either. The problem is that the uma_mutex is held over the uma->fini() call and I'm surprised that we set so tight constraints on these functions but I did not manage to corner the UMA crew and talk to them about it yesterday evening. One obvious solution is to taskq the release of the unit number. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?23463.1111232399>