Date: 24 Jun 2003 12:12:03 +0300 From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org> To: freebsd-cvsweb@FreeBSD.org Subject: Re: Contribution: show different icon for icon for binary (-kb) files and show keyword expansion mode on the log page Message-ID: <1056445923.23164.267.camel@bobcat.ods.org> In-Reply-To: <001001c338f4$2f831000$0b00000a@a2000.nl> References: <001001c338f4$2f831000$0b00000a@a2000.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2003-06-22 at 22:26, Paul Gelderblom wrote: > > The patch file included is a context diff against the current head > revision in the freebsd repository. Cool, unidiffs would be even better :) > Ville: It's a relatively small change so I hope it can be included > there .... Thanks, it looks mostly good, but a couple of remarks: - } elsif (/^head:\s+([\d\.]+)/) { + } + if (/^head:\s+([\d\.]+)/) { That hunk in readLog() would change the existing behaviour, I've changed it into: $symrev{$1} = $2; + next; } else { $symnames = 0; } - } elsif (/^head:\s+([\d\.]+)/) { + } + if (/^head:\s+([\d\.]+)/) { I also opened your .gif in Gimp and just saved it again to save almost 800 bytes :) BTW, it looks like the list ate some of your attachments but the Cc: to me worked just fine. Cheers, -- \/ille Skyttä scop at FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1056445923.23164.267.camel>