Date: Sat, 7 Dec 2019 09:05:57 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Emanuel Haupt <ehaupt@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r519189 - in head/archivers/amigadepacker: . files Message-ID: <20191207090557.GA43625@FreeBSD.org> In-Reply-To: <201912070830.xB78UFNk003275@repo.freebsd.org> References: <201912070830.xB78UFNk003275@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 07, 2019 at 08:30:15AM +0000, Emanuel Haupt wrote: > New Revision: 519189 > URL: https://svnweb.freebsd.org/changeset/ports/519189 > > Log: > Per section 4.4.3 of the Porters Handbook, REINPLACE_CMD (sed) should > not be used to replace static content. > > Switch from sed to patch. IMHO changing existing ports in this way would cause way too much of the repochurn; not too mention that the rule itself is quote dubious as sed(1) often allows for more readable and shorter code. I think this should be left at committer's and/or maintainer's discretion. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191207090557.GA43625>