Date: Sat, 3 Apr 2004 14:46:34 -0800 (PST) From: Nate Lawson <nate@root.org> To: Alexey Dokuchaev <danfe@nsu.ru> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci if_ste.c Message-ID: <20040403144540.Q11430@root.org> In-Reply-To: <20040403200844.GA18516@regency.nsu.ru> References: <20040331211028.37B5016A4E2@hub.freebsd.org> <20040331134609.N90425@root.org> <20040401105857.GA72284@regency.nsu.ru> <20040403200844.GA18516@regency.nsu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 4 Apr 2004, Alexey Dokuchaev wrote: > On Thu, Apr 01, 2004 at 04:50:11PM +0300, Ruslan Ermilov wrote: > > On Thu, Apr 01, 2004 at 05:58:57PM +0700, Alexey Dokuchaev wrote: > > > On Thu, Apr 01, 2004 at 09:42:41AM +0300, Ruslan Ermilov wrote: > > > > On Wed, Mar 31, 2004 at 01:47:16PM -0800, Nate Lawson wrote: > > [...] > > > > > This pollutes the toplevel hw sysctl space. Please move it to > > > > > hw.ste.rxsyncs or better, debug.*. > > > > > > > > > Seems I followed the bad practice from dc(4) and fxp(4). I will > > > > move it to hw.ste, thanks. > > > > > > Care to fix this "bad practice" in dc(4) and fxp(4) as well? :) Or > > > should we wait for their maintainers, or possibly filling the PR ? > > > > > Better submit a patch, it should be pretty trivial. ;) > > OK, I'll do it in a couple of days, hopefully for both dc(4) and fxp(4). Thank you. In general, I only want a PR if the problem is complex or needs further debugging. People with simple changes for code I'm active in should just send a patch. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040403144540.Q11430>