Date: Fri, 8 Feb 2019 14:32:09 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Michael Reifenberger <mr@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r492387 - head/cad/qcad Message-ID: <20190208133209.727347fetmup6tcz@ogg.in.absolight.net> In-Reply-To: <201902072236.x17Ma6SI012509@repo.freebsd.org> References: <201902072236.x17Ma6SI012509@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--zklfa4cnwcki3wwk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Feb 07, 2019 at 10:36:06PM +0000, Michael Reifenberger wrote:
> +.include <bsd.port.pre.mk>
> +
> +.if ${ARCH} =3D=3D "i386"
> +CFLAGS_${ARCH}=3D -fPIC
> +CXXFLAGS_${ARCH}=3D -fPIC
> +.endif
> +
So, what this is doing, is setting
CFLAGS_i386=3D -fPIC
CXXFLAGS_i386=3D -fPIC
Only if the arch is i386. As those variables are only ever used if the
arch is i386, maybe you could forego the test and always set the *_i386
variables. (And rollback the bsd.port.pre.mk change too)
--=20
Mathieu Arnold
--zklfa4cnwcki3wwk
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlxdhNlfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkg0uhAAr/zZK27RQjrX/c1BQ51zP1iEZDh+RSY7K5fcfNm/WTitEsGkh9spksD6
y+THbm45uqYh6wgTB1UdGBReRwxGz9abkut2r463zZIxVMoST0TFfZd7UkRrLUZY
igblbPbJUeYNhb9tgDBGYH7porbl6OCHActkK5UTHC3WQ6Eli2cx/+aMVGDwAU3a
9o7sGRSQpHNlLU6OpMgBWy/ecBXFgUa2bZuphTY0mJzQtXdTqVdA2GTck9nNbFNL
Kh02Sb+22yyF+pJ8t0C2kjElceI7LI8y+AjfJSAdJQ6euNSnc+m6HXxzI7+SWHyT
bN+bD8qnzSE/Fj+3PMzw1Zmt8S4vu3yeKu2rvjJ0hjn+XlSoK2yBZSRSJsEg0rQf
kPmJJvs1nLU4zXQCvBVGkYw+5SEwWL5TzUdwRQaWUojeELc0Ncj+lpaPvJl8SQXk
VJtUf+itdt34O8g2vl2GB3aHiG0gCaB2wszHqxZL2AV7SkvbTFAKVP/7g2J671EU
33MQxSmtuXQqGUdtx89lSmhpeBS3YB1mwzmlkgElddppsAT1OFk4gBiBTrZjgFvD
VmP1xVYUGnEYZ1IEFJk6bWiOW5OpUBj6zZBQY0qHmkgKf/zZ2AmRfQlyR0HiYjSv
cwRA+fERP3gAiWuXb1I8KzLgkbPzn+UkWoBAcwYno6IY9f9zUpQ=
=Y28x
-----END PGP SIGNATURE-----
--zklfa4cnwcki3wwk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190208133209.727347fetmup6tcz>