Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Sep 2006 23:06:45 +0400
From:      Ruslan Ermilov <ru@freebsd.org>
To:        Maksim Yevmenkin <maksim.yevmenkin@gmail.com>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/kbdmux kbdmux.c
Message-ID:  <20060919190645.GA23068@rambler-co.ru>
In-Reply-To: <bb4a86c70609190944o2438a4a4vae7b3bb2332522ee@mail.gmail.com>
References:  <200609191303.k8JD3AHl050783@repoman.freebsd.org> <bb4a86c70609190944o2438a4a4vae7b3bb2332522ee@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--EVF5PPMfhYS0aIcm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 19, 2006 at 09:44:01AM -0700, Maksim Yevmenkin wrote:
> Ruslan,
>=20
> revision 1.12 does NOT work on sparc64. it causes crash with
>=20
> panic: trap: memory address not aligned
>=20
I was affraid of something like this, but given that an argument
is 64-bit aligned, I didn't think it would be a real problem.
Can you try removing the (int) casts in front of *(intptr_t *)
and see if it helps?

> i'll try to find which particular ioctl causes it. in the mean time
> reverting everything back to (int *) casting makes everything work.
>=20
> btw, other keyboard drivers ukbd(4), atkbd(4) and sunkbd(4) use simple
> cast (int *) and NOT intptr_t.
>=20
> thanks,
> max
>=20
> On 9/19/06, Ruslan Ermilov <ru@freebsd.org> wrote:
> >ru          2006-09-19 13:03:10 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    sys/dev/kbdmux       kbdmux.c
> >  Log:
> >  Make typecast expressions comply with style(9).
> >
> >  Revision  Changes    Path
> >  1.12      +5 -5      src/sys/dev/kbdmux/kbdmux.c


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--EVF5PPMfhYS0aIcm
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFFED/FqRfpzJluFF4RAuwcAKCYJpFCiyZVgV4LJyANrbtykEs9HwCdGYUO
m6wu98Xr0Bjkeetkc1B+y4Q=
=3uKw
-----END PGP SIGNATURE-----

--EVF5PPMfhYS0aIcm--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060919190645.GA23068>