Date: Tue, 21 Jan 2014 13:52:44 -0500 From: John Baldwin <jhb@freebsd.org> To: Roger Pau Monne <roger.pau@citrix.com> Cc: julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, xen-devel@lists.xenproject.org, gibbs@freebsd.org Subject: Re: [PATCH RFC 04/13] xen: implement basic PIRQ support for Dom0 Message-ID: <201401211352.44784.jhb@freebsd.org> In-Reply-To: <1387884062-41154-5-git-send-email-roger.pau@citrix.com> References: <1387884062-41154-1-git-send-email-roger.pau@citrix.com> <1387884062-41154-5-git-send-email-roger.pau@citrix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, December 24, 2013 6:20:53 am Roger Pau Monne wrote: > This allows Dom0 to manage physical hardware, redirecting the > physical interrupts to event channels. > --- > sys/x86/xen/xen_intr.c | 190 +++++++++++++++++++++++++++++++++++++++++++++-- > sys/xen/xen_intr.h | 11 +++ > 2 files changed, 192 insertions(+), 9 deletions(-) > > diff --git a/sys/x86/xen/xen_intr.c b/sys/x86/xen/xen_intr.c > index bc0781e..340e5ed 100644 > --- a/sys/x86/xen/xen_intr.c > +++ b/sys/x86/xen/xen_intr.c > @@ -104,6 +104,8 @@ DPCPU_DECLARE(struct vcpu_info *, vcpu_info); > > #define is_valid_evtchn(x) ((x) != 0) > > +#define EEXIST 17 /* Xen "already exists" error */ Is there a xen_errno.h header? Might be nice to have one and give these constants unique names (e.g. XEN_EEXIST or some such) to avoid confusion/conflicts with <sys/errno.h>. Other than that I think this looks fine. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401211352.44784.jhb>