Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Feb 2016 19:19:50 +0000 (UTC)
From:      Ian Lepore <ian@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r409263 - in head/lang: lua51 lua52 lua53
Message-ID:  <201602201919.u1KJJo55027064@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ian
Date: Sat Feb 20 19:19:50 2016
New Revision: 409263
URL: https://svnweb.freebsd.org/changeset/ports/409263

Log:
  Use -fPIC on all arches; lua builds the object files into a shared lib.
  
  Since the object files get built into a shared lib, using -fPIC on all
  arches is the right thing to do, instead of adding it to each new arch that
  comes along which doesn't accidentally allow non-PIC modules in shared libs.
  
  PR:		207324
  Approved by:	mat(mentor)
  Differential Revision:	https://reviews.freebsd.org/D5362

Modified:
  head/lang/lua51/Makefile
  head/lang/lua52/Makefile
  head/lang/lua53/Makefile

Modified: head/lang/lua51/Makefile
==============================================================================
--- head/lang/lua51/Makefile	Sat Feb 20 19:13:22 2016	(r409262)
+++ head/lang/lua51/Makefile	Sat Feb 20 19:19:50 2016	(r409263)
@@ -52,9 +52,7 @@ LUA_SUBDIR?=	lua${PKGNAMESUFFIX}
 LUA_INCDIR?=	${LUA_PREFIX}/include/${LUA_SUBDIR}
 LUA_LIBDIR?=	${LUA_PREFIX}/lib
 
-CFLAGS_aarch64=	-fPIC
-CFLAGS_amd64=	-fPIC
-CFLAGS_powerpc=	-fPIC
+CFLAGS+=	-fPIC
 
 post-patch:
 	@${REINPLACE_CMD} -e 's,rand *(,random(,g' \

Modified: head/lang/lua52/Makefile
==============================================================================
--- head/lang/lua52/Makefile	Sat Feb 20 19:13:22 2016	(r409262)
+++ head/lang/lua52/Makefile	Sat Feb 20 19:19:50 2016	(r409263)
@@ -57,9 +57,7 @@ SUB_LIST=	version=${PORTVERSION} \
 		libdir=${LUA_LIBDIR} \
 		soname=lua-${LUA_VER}
 
-CFLAGS_aarch64=	-fPIC
-CFLAGS_amd64=	-fPIC
-CFLAGS_powerpc=	-fPIC
+CFLAGS+=	-fPIC
 
 post-patch:
 	@${REINPLACE_CMD} -e 's,rand *(,random(,g' \

Modified: head/lang/lua53/Makefile
==============================================================================
--- head/lang/lua53/Makefile	Sat Feb 20 19:13:22 2016	(r409262)
+++ head/lang/lua53/Makefile	Sat Feb 20 19:19:50 2016	(r409263)
@@ -58,9 +58,7 @@ SUB_LIST=	version=${PORTVERSION} \
 		libdir=${LUA_LIBDIR} \
 		soname=lua-${LUA_VER}
 
-CFLAGS_aarch64=	-fPIC
-CFLAGS_amd64=	-fPIC
-CFLAGS_powerpc=	-fPIC
+CFLAGS+=	-fPIC
 
 post-patch:
 	@${REINPLACE_CMD} -e 's,rand *(,random(,g' \



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201602201919.u1KJJo55027064>