Date: Mon, 08 Apr 2002 08:27:51 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/disklabel Makefile disklabel.c Message-ID: <56704.1018247271@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 08 Apr 2002 15:33:57 %2B1000." <20020408152740.N5678-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020408152740.N5678-100000@gamplex.bde.org>, Bruce Evans writes: >On Sun, 7 Apr 2002, Poul-Henning Kamp wrote: > >> phk 2002/04/07 03:57:00 PDT >> >> Modified files: >> sbin/disklabel Makefile disklabel.c >> Log: >> Get us to WARNS=2 with a bit of constification and some printf fiddling. > >WARNS=2 bogusly overrides the default, and "=" instead of "?=" breaks >overriding the default. "=" in WARNS=0 had the same bug. I've removed it entirely, 2 is the default for the sbin hierarchy and we're compatible with that now. >> Pick up the c-partitions magicness from sys/disklabel.h instead >> of defining our own magicness for it, remove trivial comment. > >This was one of the many bugs in rev.1.35. The committers and approvers >of that sort of promised to clean it up, but never did. You don't expect me to say anything to this, do you ? :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56704.1018247271>