Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Jan 2019 09:38:19 +0000 (UTC)
From:      Marcin Wojtas <mw@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r343396 - in stable/12/sys: contrib/ena-com dev/ena
Message-ID:  <201901240938.x0O9cJga007631@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mw
Date: Thu Jan 24 09:38:18 2019
New Revision: 343396
URL: https://svnweb.freebsd.org/changeset/base/343396

Log:
  MFC r343074: Suppress excessive error prints in ENA TX hotpath
  
  Sponsored by: Amazon, Inc.

Modified:
  stable/12/sys/contrib/ena-com/ena_eth_com.c
  stable/12/sys/dev/ena/ena.c
  stable/12/sys/dev/ena/ena.h

Modified: stable/12/sys/contrib/ena-com/ena_eth_com.c
==============================================================================
--- stable/12/sys/contrib/ena-com/ena_eth_com.c	Thu Jan 24 08:34:13 2019	(r343395)
+++ stable/12/sys/contrib/ena-com/ena_eth_com.c	Thu Jan 24 09:38:18 2019	(r343396)
@@ -386,7 +386,7 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,
 
 	/* num_bufs +1 for potential meta desc */
 	if (!ena_com_sq_have_enough_space(io_sq, num_bufs + 1)) {
-		ena_trc_err("Not enough space in the tx queue\n");
+		ena_trc_dbg("Not enough space in the tx queue\n");
 		return ENA_COM_NO_MEM;
 	}
 

Modified: stable/12/sys/dev/ena/ena.c
==============================================================================
--- stable/12/sys/dev/ena/ena.c	Thu Jan 24 08:34:13 2019	(r343395)
+++ stable/12/sys/dev/ena/ena.c	Thu Jan 24 09:38:18 2019	(r343396)
@@ -2813,7 +2813,7 @@ ena_xmit_mbuf(struct ena_ring *tx_ring, struct mbuf **
 	/* Prepare the packet's descriptors and send them to device */
 	rc = ena_com_prepare_tx(io_sq, &ena_tx_ctx, &nb_hw_desc);
 	if (unlikely(rc != 0)) {
-		device_printf(adapter->pdev, "failed to prepare tx bufs\n");
+		ena_trace(ENA_DBG | ENA_TXPTH, "failed to prepare tx bufs\n");
 		counter_u64_add(tx_ring->tx_stats.prepare_ctx_err, 1);
 		goto dma_error;
 	}

Modified: stable/12/sys/dev/ena/ena.h
==============================================================================
--- stable/12/sys/dev/ena/ena.h	Thu Jan 24 08:34:13 2019	(r343395)
+++ stable/12/sys/dev/ena/ena.h	Thu Jan 24 09:38:18 2019	(r343396)
@@ -41,7 +41,7 @@
 
 #define DRV_MODULE_VER_MAJOR	0
 #define DRV_MODULE_VER_MINOR	8
-#define DRV_MODULE_VER_SUBMINOR 1
+#define DRV_MODULE_VER_SUBMINOR 2
 
 #define DRV_MODULE_NAME		"ena"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901240938.x0O9cJga007631>