Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 02 Nov 2009 08:46:16 -0700 (MST)
From:      "M. Warner Losh" <imp@bsdimp.com>
To:        ed@80386.nl
Cc:        dwmalone@maths.tcd.ie, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r198706 - head/sys/sys
Message-ID:  <20091102.084616.-1258100553.imp@bsdimp.com>
In-Reply-To: <20091102102404.GP1293@hoeg.nl>
References:  <20091101011212.GG1293@hoeg.nl> <20091102100435.GA67211@walton.maths.tcd.ie> <20091102102404.GP1293@hoeg.nl>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20091102102404.GP1293@hoeg.nl>
            Ed Schouten <ed@80386.nl> writes:
: Hello David,
: 
: * David Malone <dwmalone@maths.tcd.ie> wrote:
: > Surely it is an API change, but not an ABI change? Code that used
: > to do:
: > 
: > 	d.d_uid = 3;
: > 
: > will no longer compile, but code that was comipled with the old
: > version will still run. I understand that the assignment doesn't
: > do anything useful, but I suppose there still could be code that
: > does it?
: 
: Yes, in theory there could be pieces of code that do that, but keep in
: mind that d_uid was never meant to be used by device drivers. It was
: used by devfs internally, before cdevpriv existed.
: 
: Looking at the SVN logs, it was introduced in March 2005, but it was
: already rendered useless in September that same year, when devfs was
: modified to just obtain the ownership/modes from the cdevpriv instead of
: the cdevsw.
: 
: Interesting commits:
: 
: - http://svn.freebsd.org/viewvc/base?view=revision&revision=143746
: - http://svn.freebsd.org/viewvc/base?view=revision&revision=150342

True, but you've now spent way more time than a version bump would
have taken on this.  The first of these also does a version bump. :)

And you haven't answered my question: Have you confirmed that there's
no ABI changes on all platforms?

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091102.084616.-1258100553.imp>