Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Feb 2015 23:17:47 +0800
From:      Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        John Marino <marino@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r379505 - head/databases/rocksdb
Message-ID:  <CAMHz58RTovBpCjWsdgfoRZ-aN5hOZn6-55QtQjAusbg0S5xxog@mail.gmail.com>
In-Reply-To: <201502211303.t1LD3OR8041799@svn.freebsd.org>
References:  <201502211303.t1LD3OR8041799@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 21, 2015 at 9:03 PM, John Marino <marino@freebsd.org> wrote:

> Author: marino
> Date: Sat Feb 21 13:03:23 2015
> New Revision: 379505
> URL: https://svnweb.freebsd.org/changeset/ports/379505
> QAT: https://qat.redports.org/buildarchive/r379505/
>
> Log:
>   databases/rocksdb: Remove -Werror from flags
>
>   RocksDB defines a number of variables it doesn't use, so it fails Werror
>   on modern compilers that check for this.  Remove the -Werror flag from
>   the Makefile with sed since we are using it anyway.
>
>   Approved by:  blanket
>

Though I also considered to remove -Werror, I do not think this commit is
covered by portmgr's blanket approval.

Regards,
sunpoet



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58RTovBpCjWsdgfoRZ-aN5hOZn6-55QtQjAusbg0S5xxog>