Date: Tue, 22 Jan 2013 18:33:41 +0000 From: Chris Rees <crees@FreeBSD.org> To: Brooks Davis <brooks@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r245752 - in head: etc share/mk Message-ID: <CADLo838N3PB3OS=QqJiaxJ5E78R_AekQgKw0UEyBCf=6SKrR3A@mail.gmail.com> In-Reply-To: <20130122181348.GA1662@lor.one-eyed-alien.net> References: <201301212240.r0LMedcF088022@svn.freebsd.org> <CADLo83-9-oSZkUn6u=rWuj8oh3fDEVL5oaNp-RsBJdUbFQg0cQ@mail.gmail.com> <20130122181348.GA1662@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22 January 2013 18:13, Brooks Davis <brooks@freebsd.org> wrote: > On Tue, Jan 22, 2013 at 05:55:31PM +0000, Chris Rees wrote: >> On 21 January 2013 22:40, Brooks Davis <brooks@freebsd.org> wrote: >> > Author: brooks >> > Date: Mon Jan 21 22:40:39 2013 >> > New Revision: 245752 >> > URL: http://svnweb.freebsd.org/changeset/base/245752 >> > >> > Log: >> > Replace all known uses of ln in the build process with appropriate >> > install -l invocations via new INSTALL_LINK and INSTALL_SYMLINK >> > variables. >> > >> > Sponsored by: DARPA, AFRL >> > Reviewed by: ian, ray, rpaulo >> > >> > Modified: >> > head/etc/Makefile >> > head/share/mk/bsd.incs.mk >> > head/share/mk/bsd.info.mk >> > head/share/mk/bsd.lib.mk >> > head/share/mk/bsd.links.mk >> > head/share/mk/bsd.man.mk >> > head/share/mk/bsd.own.mk >> > >> > Modified: head/etc/Makefile >> > ============================================================================== >> > --- head/etc/Makefile Mon Jan 21 22:32:00 2013 (r245751) >> > +++ head/etc/Makefile Mon Jan 21 22:40:39 2013 (r245752) >> > @@ -324,26 +324,29 @@ distrib-dirs: >> > -f $$m -p $$d; \ >> > ${MTREE_CMD} -deU ${MTREE_FOLLOWS_SYMLINKS} -f $$m -p $$d; \ >> > done; true >> > - ln -sfh usr/src/sys ${DESTDIR}/sys >> > + ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys >> >> This broke installworld for me, because of the different behaviour. >> >> ln -sf overwrites existing symlinks, whereas install -l a b puts a >> symlink to a inside itself... which fails on a read-only src (NFS >> mounted). >> >> Perhaps it's install misbehaving? I can't work out if it's >> bootstrapped properly; we should be using new install(1), are we? > > Sorry about that. It's fixed. > I presume r245793, thank you :) Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838N3PB3OS=QqJiaxJ5E78R_AekQgKw0UEyBCf=6SKrR3A>