Date: Sun, 28 Jun 2009 09:48:46 -0700 From: Jack Vogel <jfvogel@gmail.com> To: Robert Watson <rwatson@freebsd.org> Cc: Jack F Vogel <jfv@freebsd.org>, Dimitry Andric <dimitry@andric.com>, current@freebsd.org, Thomas Backman <serenity@exscape.org> Subject: Re: VMWare if_em breakage (was: Re: svn commit: r194865 - in head/sys: dev/e1000 modules/igb) Message-ID: <2a41acea0906280948x34d64510v23b17c75d9fac0b@mail.gmail.com> In-Reply-To: <alpine.BSF.2.00.0906281403140.69417@fledge.watson.org> References: <200906241741.n5OHfTaw022417@svn.freebsd.org> <alpine.BSF.2.00.0906251507090.75138@fledge.watson.org> <4A43893F.5070100@andric.com> <24BDCB76-0304-443A-96A9-71C5E537FF37@exscape.org> <alpine.BSF.2.00.0906281403140.69417@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yes, thanks Robert. I was planning on submitting this on Monday. Talk about a annoying little bug :) Jack On Sun, Jun 28, 2009 at 6:04 AM, Robert Watson <rwatson@freebsd.org> wrote: > > On Sun, 28 Jun 2009, Thomas Backman wrote: > > On Jun 25, 2009, at 04:27 PM, Dimitry Andric wrote: >> >> On 2009-06-25 16:08, Robert Watson wrote: >>> >>>> Since this change (and the two followups), I'm no longer able to use >>>> if_em reliable in VMWare Fusion. >>>> >>> >>> Same here, for VMware Workstation. The interface just stops working >>> after a bit of traffic. >>> >> >> Not sure it's needed, but here's another "me too", also using Fusion. At >> first I thought it had frozen, but locally, in the VM window, everything >> worked fine. (I always interact with VMs via SSH to get copy/paste, better >> fonts etc). Also worth mentioning is that vmware-vmx ate 100% real CPU the >> entire time, despite the VM CPU (top in FreeBSD) showed 100% *idle*. >> > > Jack suggested this patch for me to test, and it seems to work here, so > hopefully he doesn't mind my sharing it until it before it gets into SVN. > It seems to entirely prevent the problem from occuring here. > > Robert N M Watson > Computer Laboratory > University of Cambridge > > Index: if_em.c > =================================================================== > --- if_em.c (revision 195108) > +++ if_em.c (working copy) > @@ -4446,7 +4446,7 @@ > struct mbuf *mp; > u8 status, accept_frame = 0, eop = 0; > u16 len, desc_len, prev_len_adj; > - u32 i, rx_sent = 0; > + int i, rx_sent = 0; > struct e1000_rx_desc *current_desc; > > EM_RX_LOCK(adapter); > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2a41acea0906280948x34d64510v23b17c75d9fac0b>