Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 May 2016 02:58:11 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r299586 - head/usr.sbin/i2c
Message-ID:  <201605130258.u4D2wBDg061385@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Fri May 13 02:58:11 2016
New Revision: 299586
URL: https://svnweb.freebsd.org/changeset/base/299586

Log:
  i2c(8): uninitialized variable (UNINIT).
  
  If i2c_opt.width is somehow zero, the bufsize will be left uninitialized
  and make cause trouble later on.
  
  CID:		1331549

Modified:
  head/usr.sbin/i2c/i2c.c

Modified: head/usr.sbin/i2c/i2c.c
==============================================================================
--- head/usr.sbin/i2c/i2c.c	Fri May 13 01:52:41 2016	(r299585)
+++ head/usr.sbin/i2c/i2c.c	Fri May 13 02:58:11 2016	(r299586)
@@ -294,7 +294,8 @@ i2c_write(char *dev, struct options i2c_
 			err_msg = "error: offset malloc";
 			goto err1;
 		}
-	}
+	} else
+		bufsize = 0;
 
 	switch(i2c_opt.mode) {
 	case I2C_MODE_STOP_START:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605130258.u4D2wBDg061385>