Date: Tue, 25 Jan 2005 17:36:49 -0800 From: Michael Sierchio <kudzu@tenebras.com> To: lioux@FreeBSD.org Cc: ports@FreeBSD.org Subject: FreeBSD Port: qmail-1.03_3 Message-ID: <41F6F431.6060005@tenebras.com>
next in thread | raw e-mail | index | archive | help
You have added a patch which is totally unneccesary, and I suggest that it be removed: in your patch-qmail-local.... - while ((k > i) && (cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t')) + while ((k > i) && ((cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t'))) This is totally bogus, the original code is correct. Please do not make changes to contributed code simply because it makes it easier for you to understand. There is no semantic difference between the two, ERGO the patch should not exist. Please remove it. Shall I file a PR? - Michael
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41F6F431.6060005>