Date: Thu, 20 Oct 2016 11:18:27 -0700 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307650 - head/sys/kern Message-ID: <20161020181827.GU27748@FreeBSD.org> In-Reply-To: <20161020115035.GA26990@dft-labs.eu> References: <201610191829.u9JITqhm081246@repo.freebsd.org> <20161019220942.GM27748@FreeBSD.org> <20161020115035.GA26990@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 20, 2016 at 01:50:35PM +0200, Mateusz Guzik wrote: M> On Wed, Oct 19, 2016 at 03:09:42PM -0700, Gleb Smirnoff wrote: M> > On Wed, Oct 19, 2016 at 06:29:52PM +0000, Mateusz Guzik wrote: M> > M> Author: mjg M> > M> Date: Wed Oct 19 18:29:52 2016 M> > M> New Revision: 307650 M> > M> URL: https://svnweb.freebsd.org/changeset/base/307650 M> > M> M> > M> Log: M> > M> cache: split negative entry LRU into multiple lists M> > M> M> > M> This splits the ncneg_mtx lock while preserving the hit ratio at least M> > M> during buildworld. M> > M> M> > M> Create N dedicated lists for new negative entries. M> > M> M> > M> Entries with at least one hit get promoted to the hot list, where they M> > M> get requeued every M hits. M> > M> M> > M> Shrinking demotes one hot entry and performs a round-robin shrinking of M> > M> regular lists. M> > M> M> > M> Reviewed by: kib M> > M> > This instapanics: M> > M> > panic: Assertion ncp->nc_flag & NCF_NEGATIVE failed at /usr/src/head/sys/kern/vfs_cache.c:815 M> > M> M> It definitely works for me and I don't see how the condition can fail. M> M> Given the 'instapanic' note, I assume you can easily reproduce. Is this M> a stock head kernel? M> M> Can you reproduce with; Trying to mount root from ufs:/dev/vtbd0p3 [rw]... panic: cache_negative_zap_one: ncp 0xffffffff81012500 flag 0 dvp 0 vp 0 cpuid = 11 KDB: enter: panic [ thread pid 21 tid 100097 ] Stopped at breakpoint+0x5: popq %rbp db> bt Tracing pid 21 tid 100097 td 0xfffff8000342ca00 breakpoint() at breakpoint+0x5/frame 0xfffffe00f7e8da90 kdb_enter() at kdb_enter+0x67/frame 0xfffffe00f7e8dac0 vpanic() at vpanic+0x26b/frame 0xfffffe00f7e8db90 kproc_shutdown() at kproc_shutdown/frame 0xfffffe00f7e8dbf0 cache_negative_zap_one() at cache_negative_zap_one+0x313/frame 0xfffffe00f7e8dcb0 cache_enter_time() at cache_enter_time+0xe5a/frame 0xfffffe00f7e8de10 ufs_lookup_ino() at ufs_lookup_ino+0xaf1/frame 0xfffffe00f7e8e030 ufs_lookup() at ufs_lookup+0x39/frame 0xfffffe00f7e8e050 VOP_CACHEDLOOKUP_APV() at VOP_CACHEDLOOKUP_APV+0x20a/frame 0xfffffe00f7e8e0d0 VOP_CACHEDLOOKUP() at VOP_CACHEDLOOKUP+0x4d/frame 0xfffffe00f7e8e120 vfs_cache_lookup() at vfs_cache_lookup+0x148/frame 0xfffffe00f7e8e190 VOP_LOOKUP_APV() at VOP_LOOKUP_APV+0x20a/frame 0xfffffe00f7e8e210 VOP_LOOKUP() at VOP_LOOKUP+0x4d/frame 0xfffffe00f7e8e260 lookup() at lookup+0xa02/frame 0xfffffe00f7e8e3a0 namei() at namei+0x9c6/frame 0xfffffe00f7e8e550 kern_statat() at kern_statat+0x16d/frame 0xfffffe00f7e8e7c0 sys_stat() at sys_stat+0x89/frame 0xfffffe00f7e8e8b0 syscallenter() at syscallenter+0x54f/frame 0xfffffe00f7e8e980 amd64_syscall() at amd64_syscall+0x2a/frame 0xfffffe00f7e8eab0 Xfast_syscall() at Xfast_syscall+0xfb/frame 0xfffffe00f7e8eab0 --- syscall (188, FreeBSD ELF64, sys_stat), rip = 0x800bd391a, rsp = 0x7fffffffe9a8, rbp = 0x7fffffffea90 --- db> -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161020181827.GU27748>