Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 7 Sep 2021 12:09:49 GMT
From:      Jessica Clarke <jrtc27@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 276455b32167 - stable/13 - sifive_prci: Delay attachment until after clk_fixed
Message-ID:  <202109071209.187C9n5U087401@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by jrtc27:

URL: https://cgit.FreeBSD.org/src/commit/?id=276455b32167e1cee0fde86c4387ca1f36b5b2ba

commit 276455b32167e1cee0fde86c4387ca1f36b5b2ba
Author:     Jessica Clarke <jrtc27@FreeBSD.org>
AuthorDate: 2021-08-07 18:27:29 +0000
Commit:     Jessica Clarke <jrtc27@FreeBSD.org>
CommitDate: 2021-09-07 12:06:50 +0000

    sifive_prci: Delay attachment until after clk_fixed
    
    This avoids noisy output from early attempts to attach before clk_fixed
    has attached to the parent clocks.
    
    Reviewed by:    kp, mhorne
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D31023
    
    (cherry picked from commit dcbea9a2f465be1786db21523a7f55db3f7ab3dd)
---
 sys/riscv/sifive/sifive_prci.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sys/riscv/sifive/sifive_prci.c b/sys/riscv/sifive/sifive_prci.c
index 21b9cd568f32..36f2f6705f7e 100644
--- a/sys/riscv/sifive/sifive_prci.c
+++ b/sys/riscv/sifive/sifive_prci.c
@@ -638,5 +638,9 @@ static driver_t prci_driver = {
 
 static devclass_t prci_devclass;
 
+/*
+ * hfclk and rtcclk appear later in the device tree than prci, so we must
+ * attach late.
+ */
 EARLY_DRIVER_MODULE(sifive_prci, simplebus, prci_driver, prci_devclass, 0, 0,
-    BUS_PASS_BUS);
+    BUS_PASS_BUS + BUS_PASS_ORDER_LATE);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202109071209.187C9n5U087401>